Make ws a direct dependency#1163
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 8beb207 The changes in this PR will be included in the next version bump. This PR includes changesets to release 43 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
BundleMonUnchanged files (136)
No change in files bundle size Final result: ✅ View report in BundleMon website ➡️ |
Contributor
|
Documentation Preview: https://kit-docs-hbk20a8jw-anza-tech.vercel.app |
mcintyre94
requested changes
Jan 7, 2026
Member
mcintyre94
left a comment
mcintyre94
left a comment
There was a problem hiding this comment.
Agreed with this change, I think it makes most sense as a direct dependency. I think you accidentally removed the typescript peer dependency though.
lorisleiva
force-pushed
the
01-07-make_ws_a_direct_dependency
branch
from
2abb466 to
eba8dbb
Compare
lorisleiva
force-pushed
the
01-07-make_ws_a_direct_dependency
branch
from
eba8dbb to
8beb207
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub. |
Contributor
|
🔎💬 Inkeep AI search and chat service is syncing content for source 'Solana Kit Docs' |
Merged
Merged
Contributor
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Currently, Node users must explicitly install
wsas a peer dependency to use RPC Subscription features. This creates onboarding friction as users need to understand what isws, which environment requires it and why it is required just to get started with Kit.Summary of Changes
This PR move
wsfrompeerDependenciestodependencies. Since the packages use conditional exports with separate entry points for Node and browser environments, browser builds will never includewsas the browser entry point simply doesn't import it.This means Node users get
wsout of the box while browser bundle sizes remain unaffected.