Remove NO_CONFIG hack in RPC methods with no parameters (#236)

steveluscher · web-flow · commit ca1d4ec7ddd6 · 2025-03-19T15:48:33.000-07:00
diff --git a/.changeset/beige-tips-kiss.md b/.changeset/beige-tips-kiss.md
@@ -0,0 +1,5 @@
+---
+'@solana/rpc-api': patch
+---
+
+RPC methods that take no parameters no longer rely on having a placeholder `NO_CONFIG` argument. Removing it will save you from wondering why it exists.
diff --git a/.changeset/silent-berries-know.md b/.changeset/silent-berries-know.md
@@ -0,0 +1,42 @@
+---
+'@solana/rpc-subscriptions-channel-websocket': patch
+'@solana/webcrypto-ed25519-polyfill': patch
+'@solana/transaction-confirmation': patch
+'@solana/codecs-data-structures': patch
+'@solana/rpc-subscriptions-spec': patch
+'@solana/fast-stable-stringify': patch
+'@solana/rpc-subscriptions-api': patch
+'@solana/transaction-messages': patch
+'@solana/rpc-transport-http': patch
+'@solana/rpc-subscriptions': patch
+'@solana/rpc-parsed-types': patch
+'@solana/rpc-transformers': patch
+'@solana/codecs-numbers': patch
+'@solana/codecs-strings': patch
+'@solana/rpc-spec-types': patch
+'@solana/instructions': patch
+'@solana/subscribable': patch
+'@solana/transactions': patch
+'@solana/codecs-core': patch
+'@solana/rpc-graphql': patch
+'@solana/assertions': patch
+'@solana/functional': patch
+'@solana/addresses': patch
+'@solana/rpc-types': patch
+'@solana/accounts': patch
+'@solana/programs': patch
+'@solana/promises': patch
+'@solana/rpc-spec': patch
+'@solana/options': patch
+'@solana/rpc-api': patch
+'@solana/signers': patch
+'@solana/sysvars': patch
+'@solana/codecs': patch
+'@solana/compat': patch
+'@solana/errors': patch
+'@solana/keys': patch
+'@solana/kit': patch
+'@solana/rpc': patch
+---
+
+The minimum TypeScript version is now 5.3.3
diff --git a/packages/accounts/package.json b/packages/accounts/package.json
@@ -79,7 +79,7 @@
         "@solana/rpc-types": "workspace:*"
     },
     "peerDependencies": {
-        "typescript": ">=5"
+        "typescript": ">=5.3.3"
     },
     "engines": {
         "node": ">=20.18.0"
diff --git a/packages/addresses/package.json b/packages/addresses/package.json
@@ -77,7 +77,7 @@
         "@solana/errors": "workspace:*"
     },
     "peerDependencies": {
-        "typescript": ">=5"
+        "typescript": ">=5.3.3"
     },
     "engines": {
         "node": ">=20.18.0"
diff --git a/packages/assertions/package.json b/packages/assertions/package.json
@@ -74,7 +74,7 @@
         "@solana/errors": "workspace:*"
     },
     "peerDependencies": {
-        "typescript": ">=5"
+        "typescript": ">=5.3.3"
     },
     "engines": {
         "node": ">=20.18.0"
diff --git a/packages/codecs-core/package.json b/packages/codecs-core/package.json
@@ -78,7 +78,7 @@
         "tinybench": "^4.0.1"
     },
     "peerDependencies": {
-        "typescript": ">=5"
+        "typescript": ">=5.3.3"
     },
     "engines": {
         "node": ">=20.18.0"
diff --git a/packages/codecs-data-structures/package.json b/packages/codecs-data-structures/package.json
@@ -79,7 +79,7 @@
         "@solana/codecs-strings": "workspace:*"
     },
     "peerDependencies": {
-        "typescript": ">=5"
+        "typescript": ">=5.3.3"
     },
     "engines": {
         "node": ">=20.18.0"
diff --git a/packages/codecs-numbers/package.json b/packages/codecs-numbers/package.json
@@ -75,7 +75,7 @@
         "@solana/errors": "workspace:*"
     },
     "peerDependencies": {
-        "typescript": ">=5"
+        "typescript": ">=5.3.3"
     },
     "engines": {
         "node": ">=20.18.0"
diff --git a/packages/codecs-strings/package.json b/packages/codecs-strings/package.json
@@ -82,7 +82,7 @@
     },
     "peerDependencies": {
         "fastestsmallesttextencoderdecoder": "^1.0.22",
-        "typescript": ">=5"
+        "typescript": ">=5.3.3"
     },
     "engines": {
         "node": ">=20.18.0"
diff --git a/packages/codecs/package.json b/packages/codecs/package.json
@@ -76,7 +76,7 @@
         "@solana/options": "workspace:*"
     },
     "peerDependencies": {
-        "typescript": ">=5"
+        "typescript": ">=5.3.3"
     },
     "engines": {
         "node": ">=20.18.0"
diff --git a/packages/compat/package.json b/packages/compat/package.json
@@ -83,7 +83,7 @@
         "@solana/web3.js": "^1"
     },
     "peerDependencies": {
-        "typescript": ">=5"
+        "typescript": ">=5.3.3"
     },
     "engines": {
         "node": ">=20.18.0"
diff --git a/packages/errors/package.json b/packages/errors/package.json
@@ -76,7 +76,7 @@
         "commander": "^13.1.0"
     },
     "peerDependencies": {
-        "typescript": ">=5"
+        "typescript": ">=5.3.3"
     },
     "engines": {
         "node": ">=20.18.0"
diff --git a/packages/fast-stable-stringify/package.json b/packages/fast-stable-stringify/package.json
@@ -78,7 +78,7 @@
         "maintained node versions"
     ],
     "peerDependencies": {
-        "typescript": ">=5"
+        "typescript": ">=5.3.3"
     },
     "engines": {
         "node": ">=20.18.0"
diff --git a/packages/functional/package.json b/packages/functional/package.json
@@ -71,7 +71,7 @@
         "maintained node versions"
     ],
     "peerDependencies": {
-        "typescript": ">=5"
+        "typescript": ">=5.3.3"
     },
     "engines": {
         "node": ">=20.18.0"
diff --git a/packages/instructions/package.json b/packages/instructions/package.json
@@ -78,7 +78,7 @@
         "@solana/addresses": "workspace:*"
     },
     "peerDependencies": {
-        "typescript": ">=5"
+        "typescript": ">=5.3.3"
     },
     "engines": {
         "node": ">=20.18.0"
diff --git a/packages/keys/package.json b/packages/keys/package.json
@@ -78,7 +78,7 @@
         "@solana/errors": "workspace:*"
     },
     "peerDependencies": {
-        "typescript": ">=5"
+        "typescript": ">=5.3.3"
     },
     "devDependencies": {
         "tinybench": "^4.0.1"
diff --git a/packages/kit/package.json b/packages/kit/package.json
@@ -94,7 +94,7 @@
         "@solana/transactions": "workspace:*"
     },
     "peerDependencies": {
-        "typescript": ">=5"
+        "typescript": ">=5.3.3"
     },
     "engines": {
         "node": ">=20.18.0"
diff --git a/packages/options/package.json b/packages/options/package.json
@@ -78,7 +78,7 @@
         "@solana/errors": "workspace:*"
     },
     "peerDependencies": {
-        "typescript": ">=5"
+        "typescript": ">=5.3.3"
     },
     "engines": {
         "node": ">=20.18.0"
diff --git a/packages/programs/package.json b/packages/programs/package.json
@@ -79,7 +79,7 @@
         "@solana/transaction-messages": "workspace:*"
     },
     "peerDependencies": {
-        "typescript": ">=5"
+        "typescript": ">=5.3.3"
     },
     "engines": {
         "node": ">=20.18.0"
diff --git a/packages/promises/package.json b/packages/promises/package.json
@@ -71,7 +71,7 @@
         "maintained node versions"
     ],
     "peerDependencies": {
-        "typescript": ">=5"
+        "typescript": ">=5.3.3"
     },
     "engines": {
         "node": ">=20.18.0"
diff --git a/packages/rpc-api/package.json b/packages/rpc-api/package.json
@@ -88,7 +88,7 @@
         "@solana/rpc-transport-http": "workspace:*"
     },
     "peerDependencies": {
-        "typescript": ">=5"
+        "typescript": ">=5.3.3"
     },
     "engines": {
         "node": ">=20.18.0"
diff --git a/packages/rpc-api/src/getClusterNodes.ts b/packages/rpc-api/src/getClusterNodes.ts
@@ -42,10 +42,6 @@ type GetClusterNodesApiResponse = readonly ClusterNode[];
 export type GetClusterNodesApi = {
     /**
      * Returns information about all the nodes participating in the cluster
-     * Note that the optional NO_CONFIG object is ignored. See https://github.com/solana-labs/solana-web3.js/issues/1389
      */
-    getClusterNodes(
-        // FIXME: https://github.com/solana-labs/solana-web3.js/issues/1389
-        NO_CONFIG?: Record<string, never>,
-    ): GetClusterNodesApiResponse;
+    getClusterNodes(): GetClusterNodesApiResponse;
 };
diff --git a/packages/rpc-api/src/getEpochSchedule.ts b/packages/rpc-api/src/getEpochSchedule.ts
@@ -14,10 +14,6 @@ type GetEpochScheduleApiResponse = Readonly<{
 export type GetEpochScheduleApi = {
     /**
      * Returns the epoch schedule information from this cluster's genesis config
-     * Note that the optional NO_CONFIG object is ignored. See https://github.com/solana-labs/solana-web3.js/issues/1389
      */
-    getEpochSchedule(
-        // FIXME: https://github.com/solana-labs/solana-web3.js/issues/1389
-        NO_CONFIG?: Record<string, never>,
-    ): GetEpochScheduleApiResponse;
+    getEpochSchedule(): GetEpochScheduleApiResponse;
 };
diff --git a/packages/rpc-api/src/getFirstAvailableBlock.ts b/packages/rpc-api/src/getFirstAvailableBlock.ts
@@ -5,10 +5,6 @@ type GetFirstAvailableBlockApiResponse = Slot;
 export type GetFirstAvailableBlockApi = {
     /**
      * Returns the slot of the lowest confirmed block that has not been purged from the ledger
-     * Note that the optional NO_CONFIG object is ignored. See https://github.com/solana-labs/solana-web3.js/issues/1389
      */
-    getFirstAvailableBlock(
-        // FIXME: https://github.com/solana-labs/solana-web3.js/issues/1389
-        NO_CONFIG?: Record<string, never>,
-    ): GetFirstAvailableBlockApiResponse;
+    getFirstAvailableBlock(): GetFirstAvailableBlockApiResponse;
 };
diff --git a/packages/rpc-api/src/getGenesisHash.ts b/packages/rpc-api/src/getGenesisHash.ts
@@ -6,8 +6,5 @@ export type GetGenesisHashApi = {
     /**
      * Returns the genesis hash
      */
-    getGenesisHash(
-        // FIXME: https://github.com/solana-labs/solana-web3.js/issues/1389
-        NO_CONFIG?: Record<string, never>,
-    ): GetGenesisHashApiResponse;
+    getGenesisHash(): GetGenesisHashApiResponse;
 };
diff --git a/packages/rpc-api/src/getHealth.ts b/packages/rpc-api/src/getHealth.ts
@@ -4,8 +4,5 @@ export type GetHealthApi = {
     /**
      * Returns the health status of the node ("ok" if healthy).
      */
-    getHealth(
-        // FIXME: https://github.com/solana-labs/solana-web3.js/issues/1389
-        NO_CONFIG?: Record<string, never>,
-    ): GetHealthApiResponse;
+    getHealth(): GetHealthApiResponse;
 };
diff --git a/packages/rpc-api/src/getHighestSnapshotSlot.ts b/packages/rpc-api/src/getHighestSnapshotSlot.ts
@@ -13,8 +13,5 @@ export type GetHighestSnapshotSlotApi = {
      * incremental snapshot slot based on the full snapshot slot, if there
      * is one.
      */
-    getHighestSnapshotSlot(
-        // FIXME: https://github.com/solana-labs/solana-web3.js/issues/1389
-        NO_CONFIG?: Record<string, never>,
-    ): GetHighestSnapshotSlotApiResponse;
+    getHighestSnapshotSlot(): GetHighestSnapshotSlotApiResponse;
 };
diff --git a/packages/rpc-api/src/getIdentity.ts b/packages/rpc-api/src/getIdentity.ts
@@ -8,8 +8,5 @@ export type GetIdentityApi = {
     /**
      * Returns the identity pubkey for the current node
      */
-    getIdentity(
-        // FIXME: https://github.com/solana-labs/solana-web3.js/issues/1389
-        NO_CONFIG?: Record<string, never>,
-    ): GetIdentityApiResponse;
+    getIdentity(): GetIdentityApiResponse;
 };
diff --git a/packages/rpc-api/src/getInflationRate.ts b/packages/rpc-api/src/getInflationRate.ts
@@ -15,8 +15,5 @@ export type GetInflationRateApi = {
     /**
      * Returns the specific inflation values for the current epoch
      */
-    getInflationRate(
-        // FIXME: https://github.com/solana-labs/solana-web3.js/issues/1389
-        NO_CONFIG?: Record<string, never>,
-    ): GetInflationRateApiResponse;
+    getInflationRate(): GetInflationRateApiResponse;
 };
diff --git a/packages/rpc-api/src/getMaxRetransmitSlot.ts b/packages/rpc-api/src/getMaxRetransmitSlot.ts
@@ -5,10 +5,6 @@ type GetMaxRetransmitSlotApiResponse = Slot;
 export type GetMaxRetransmitSlotApi = {
     /**
      * Get the max slot seen from retransmit stage.
-     * Note that the optional NO_CONFIG object is ignored. See https://github.com/solana-labs/solana-web3.js/issues/1389
      */
-    getMaxRetransmitSlot(
-        // FIXME: https://github.com/solana-labs/solana-web3.js/issues/1389
-        NO_CONFIG?: Record<string, never>,
-    ): GetMaxRetransmitSlotApiResponse;
+    getMaxRetransmitSlot(): GetMaxRetransmitSlotApiResponse;
 };
diff --git a/packages/rpc-api/src/getMaxShredInsertSlot.ts b/packages/rpc-api/src/getMaxShredInsertSlot.ts
@@ -5,10 +5,6 @@ type GetMaxShredInsertSlotApiResponse = Slot;
 export type GetMaxShredInsertSlotApi = {
     /**
      * Get the max slot seen from after shred insert.
-     * Note that the optional NO_CONFIG object is ignored. See https://github.com/solana-labs/solana-web3.js/issues/1389
      */
-    getMaxShredInsertSlot(
-        // FIXME: https://github.com/solana-labs/solana-web3.js/issues/1389
-        NO_CONFIG?: Record<string, never>,
-    ): GetMaxShredInsertSlotApiResponse;
+    getMaxShredInsertSlot(): GetMaxShredInsertSlotApiResponse;
 };
diff --git a/packages/rpc-api/src/getVersion.ts b/packages/rpc-api/src/getVersion.ts
@@ -9,8 +9,5 @@ export type GetVersionApi = {
     /**
      * Returns the current Solana version running on the node
      */
-    getVersion(
-        // FIXME: https://github.com/solana-labs/solana-web3.js/issues/1389
-        NO_CONFIG?: Record<string, never>,
-    ): GetVersionApiResponse;
+    getVersion(): GetVersionApiResponse;
 };
diff --git a/packages/rpc-graphql/package.json b/packages/rpc-graphql/package.json
@@ -85,7 +85,7 @@
         "@solana/transactions": "workspace:*"
     },
     "peerDependencies": {
-        "typescript": ">=5"
+        "typescript": ">=5.3.3"
     },
     "engines": {
         "node": ">=20.18.0"
diff --git a/packages/rpc-parsed-types/package.json b/packages/rpc-parsed-types/package.json
@@ -73,7 +73,7 @@
         "@solana/rpc-types": "workspace:*"
     },
     "peerDependencies": {
-        "typescript": ">=5"
+        "typescript": ">=5.3.3"
     },
     "engines": {
         "node": ">=20.18.0"
diff --git a/packages/rpc-spec-types/package.json b/packages/rpc-spec-types/package.json
@@ -71,7 +71,7 @@
         "maintained node versions"
     ],
     "peerDependencies": {
-        "typescript": ">=5"
+        "typescript": ">=5.3.3"
     },
     "engines": {
         "node": ">=20.18.0"
diff --git a/packages/rpc-spec/package.json b/packages/rpc-spec/package.json
@@ -75,7 +75,7 @@
         "@solana/rpc-spec-types": "workspace:*"
     },
     "peerDependencies": {
-        "typescript": ">=5"
+        "typescript": ">=5.3.3"
     },
     "engines": {
         "node": ">=20.18.0"
diff --git a/packages/rpc-subscriptions-api/package.json b/packages/rpc-subscriptions-api/package.json
@@ -83,7 +83,7 @@
         "@solana/rpc-subscriptions-channel-websocket": "workspace:*"
     },
     "peerDependencies": {
-        "typescript": ">=5"
+        "typescript": ">=5.3.3"
     },
     "engines": {
         "node": ">=20.18.0"
diff --git a/packages/rpc-subscriptions-api/src/root-notifications.ts b/packages/rpc-subscriptions-api/src/root-notifications.ts
@@ -6,8 +6,5 @@ export type RootNotificationsApi = {
     /**
      * Subscribe to receive notification anytime a new root is set by the validator
      */
-    rootNotifications(
-        // FIXME: https://github.com/solana-labs/solana-web3.js/issues/1389
-        NO_CONFIG?: Record<string, never>,
-    ): RootNotificationsApiNotification;
+    rootNotifications(): RootNotificationsApiNotification;
 };
diff --git a/packages/rpc-subscriptions-api/src/slot-notifications.ts b/packages/rpc-subscriptions-api/src/slot-notifications.ts
diff --git a/packages/rpc-subscriptions-api/src/slots-updates-notifications.ts b/packages/rpc-subscriptions-api/src/slots-updates-notifications.ts
diff --git a/packages/rpc-subscriptions-api/src/vote-notifications.ts b/packages/rpc-subscriptions-api/src/vote-notifications.ts
diff --git a/packages/rpc-subscriptions-channel-websocket/package.json b/packages/rpc-subscriptions-channel-websocket/package.json
diff --git a/packages/rpc-subscriptions-spec/package.json b/packages/rpc-subscriptions-spec/package.json
diff --git a/packages/rpc-subscriptions/package.json b/packages/rpc-subscriptions/package.json
diff --git a/packages/rpc-transformers/package.json b/packages/rpc-transformers/package.json
diff --git a/packages/rpc-transport-http/package.json b/packages/rpc-transport-http/package.json
diff --git a/packages/rpc-types/package.json b/packages/rpc-types/package.json
diff --git a/packages/rpc/package.json b/packages/rpc/package.json
diff --git a/packages/signers/package.json b/packages/signers/package.json
diff --git a/packages/subscribable/package.json b/packages/subscribable/package.json
diff --git a/packages/sysvars/package.json b/packages/sysvars/package.json
diff --git a/packages/transaction-confirmation/package.json b/packages/transaction-confirmation/package.json
diff --git a/packages/transaction-messages/package.json b/packages/transaction-messages/package.json
diff --git a/packages/transactions/package.json b/packages/transactions/package.json
diff --git a/packages/webcrypto-ed25519-polyfill/package.json b/packages/webcrypto-ed25519-polyfill/package.json
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
