Async vote prototype: do not review #4051

wen-coding · 2024-12-11T04:44:56Z

This is the Async vote prototype meant for testing, do not review this.

… vote only replay.

…xecute non-commited votes.

mergify · 2024-12-11T04:45:30Z

If this PR represents a change to the public RPC API:

Make sure it includes a complementary update to rpc-client/ (example)
Open a follow-up PR to update the JavaScript client @solana/web3.js (example)

Thank you for keeping the RPC clients in sync with the server API @wen-coding.

mergify · 2024-12-11T04:45:31Z

The Firedancer team maintains a line-for-line reimplementation of the
native programs, and until native programs are moved to BPF, those
implementations must exactly match their Agave counterparts.
If this PR represents a change to a native program implementation (not
tests), please include a reviewer from the Firedancer team. And please
keep refactors to a minimum.

wen-coding added 30 commits October 14, 2024 19:56

Add vote_only_hash and parent_vote_only_hash.

e165944

Use vote_only_hash in ForkProgress.

3ebbdb6

Add FinalReplayStage.

684f714

Correctly set replay_tip_slot/hash in TowerSync.

e271804

Use vote_only_hash in bank_forks.

e9ecb18

Replace hash with vote_only_hash in a few more places.

00b845c

Do vote_only_freeze for bank0.

a115b5a

Use vote_only_hash in heaviest_subtree_fork_choice.

b5b0612

Add missing fields to SerializableVersionedBank.

78f9966

Print both hashes on logs.

59a701c

Avoid deadlock.

48065db

Do not register ticks in final replay, they are registered already in…

76da1b5

… vote only replay.

Add skip_commit to execution.

41a5c82

Save VoteState in the bank and update them in vote_only_replay.

bbb8290

Update VoteState across epoch boundary.

f9d5d05

Do not register tick in vote only execution.

6b47f23

Separate tick_height for two replay stages.

926b70c

Perform both replay stages when processing bank0 and single slot.

6644fb5

Bug fixes.

51e0e90

Bug fixes.

4d5c6b7

Correctly set initial blockhash in final replay.

154b2f0

Need vote_only_freeze in squash or warp.

839dabf

Add additional freeze in warp_from_parent.

f8be688

Set tick height correctly in warp_from_parent.

11ced03

Bug fixes.

21aeb1b

Also cache slot_hashes in bank.

d0dd0e4

Add slot_hashes to SerializableVersionedBank.

2997f22

Replace frozen_banks with vote_only_frozen_banks where applicable.

592acab

Copy tick height from parent before the final replay.

e73fa0c

Update replay tip in vote_state from votes.

c7e73ea

wen-coding added 27 commits December 2, 2024 10:32

bank0 should have a default BankFullReplayFields.

551b184

Store max_tick_height into tick_height in warp_from_parent.

bec81aa

Also need to copy data from parent if this bank is created by myself.

99a2540

Move blockhash_queue into full_replay_fields.

292f4f1

block 0 should have default full_replay_fields.

3237c44

Put in temporary hack to make epoch_rewards not panic.

fc812ac

No need to reset full replay for bank0, already reset in new_from_path.

3be5cc6

Use last_vote_only_blockhash in replay.

0a93b01

Copy parent data earlier.

8233333

Fix lint error.

5c0d91d

Reset bank should use vote only blockhash as well.

aea8270

When checking transactions, use the vote only blockhash queue.

72e66fe

Move capitalization into full_replay_fields.

6ef0d81

Set up capitalization on bank 0.

5eaf05c

Move epoch_reward_status into full_replay_fields.

e45963c

Move sysvar update to later when the bank is frozen.

9c5692a

Update stakes_cache and epoch_stakes when parent is frozen.

c05db4d

Compare stakes in new_epoch_stakes.

2bdf390

Do not compare epoch_stakes for now.

f869bb7

Correctly initialize place holder for epoch 0.

e2fa4ef

Always copy over vote accounts for now.

ae3657d

Only update vote states on epoch boundary or at the beginning.

3b1254f

Use last_vote_only_blockhash in vote_only_execution.

c512b60

Handle the case where bank does not exist any more in full replay stage.

62e1ca4

Remove dead lock on bank_forks.

460a51f

Try moving vote only execution of working bank to later so we don't e…

915b466

…xecute non-commited votes.

Fix typo.

ad5a42d

wen-coding self-assigned this Dec 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Async vote prototype: do not review #4051

Async vote prototype: do not review #4051

wen-coding commented Dec 11, 2024

mergify bot commented Dec 11, 2024

mergify bot commented Dec 11, 2024

Async vote prototype: do not review #4051

Are you sure you want to change the base?

Async vote prototype: do not review #4051

Conversation

wen-coding commented Dec 11, 2024

mergify bot commented Dec 11, 2024

mergify bot commented Dec 11, 2024