blockstore: Use Vec::from() instead of slice::to_vec() #4047
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Vec::from() on a Box<[T]> takes over the heap allocation whereas slice::to_vec() copies the contents into a new Vec. We don't need the old Box<[u8]> so transferring ownership is sufficient here
Summary of Changes
Use
Vec::from()
instead ofto_vec()
. Playing with it on godbolt, we save amovzx
when optimization cranked up. So, not something that will move the needle on TPS or anything, but I view this more as a correctness thing too.https://godbolt.org/z/Wbs6v6vEs