Extract rpc response crate (attempt 2) #2961
Open
+683
−604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this PR represents a change to the public RPC API:
Thank you for keeping the RPC clients in sync with the server API @kevinheavey. |
kevinheavey
force-pushed
the
extract-rpc-response2
branch
2 times, most recently
from
dc894fe to
2d46f67
Compare
kevinheavey
force-pushed
the
extract-rpc-response2
branch
3 times, most recently
from
ec4dc44 to
4a3ed0f
Compare
kevinheavey
force-pushed
the
extract-rpc-response2
branch
2 times, most recently
from
8b326a0 to
1c4a2a4
Compare
kevinheavey
force-pushed
the
extract-rpc-response2
branch
from
1c4a2a4 to
3d1fea4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made a mess of #2084 in a rebase, easier to make a new PR.
Problem
It would be great to import RPC response parsing code without relying on the request-building code - it it not uncommon to want one without the other. Pulling out the response-parsing code allows you to avoid the jsonrpc-core and reqwest dependencies, which are very heavy.
Summary of Changes
Move
solana_rpc_client_api::response(except for theRpcResultalias) to its own crate, and re-export for backwards compatibility.