Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag to skip genesis account creation in solana-genesis #2094

Closed
wants to merge 1 commit into from

Conversation

FarinM
Copy link

@FarinM FarinM commented Jul 11, 2024

Problem

During solana-genesis, the genesis account list automatically gets added for all cluster types that aren't of type development. At the same time, development enables all feature gates which can be unfavorable and unwanted for spinning up private networks.

Summary of Changes

Add optional --skip-genesis-accounts flag

@mergify mergify bot requested a review from a team July 11, 2024 17:04
@FarinM FarinM closed this Jul 11, 2024
@steviez
Copy link

steviez commented Jul 11, 2024

Hi @FarinM - I see you closed the PR. I don't think we'd accept your PR as is, but there has been some previous work in the area. Namely, check out #1584

I'm not sure if we'll ship that PR because of the RPC dependency pull-in. However, I think at least having the ability to deactivate individual features like you can in test-validator has value. I'll ping the author of 1584 to see where they're at

@FarinM
Copy link
Author

FarinM commented Jul 11, 2024

Hi, sorry. This pr was created from the wrong fork which is why I closed it. #2096, is the correct one. My apologies.

We're open to make any changes needed for this. I definitely agree that managing the individual features needs some QOL improvements, which was the original idea behind this. If #1584 isn't being continued, we can on our end add args for enabling / disabling certain features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants