Skip to content

v4.0: feat: enable direct-io in accounts-db snapshot operations with opt-out flag (backport of #10790)#11153

Merged
kskalski merged 3 commits into
v4.0from
mergify/bp/v4.0/pr-10790
Mar 12, 2026
Merged

v4.0: feat: enable direct-io in accounts-db snapshot operations with opt-out flag (backport of #10790)#11153
kskalski merged 3 commits into
v4.0from
mergify/bp/v4.0/pr-10790

Conversation

@mergify
Copy link
Copy Markdown

@mergify mergify Bot commented Mar 10, 2026

Problem

#10507 added support to enable direct-io for snapshot operations (currently applied to unpacking accounts-db storage files) by config field.
It's enabled for tests, we want to enable it for validator and ledger-tool with an opt-out flag in case given file-system doesn't properly support direct-io.

Summary of Changes

Add a validator and ledger-tool flag to control enabling direct-io for snapshot related operations. It is enabled by default, since in the tests it yields overall better startup / ledger-tool run time.

Performance impact
  • master:
snapshot untar took 111.8s
Building accounts index... Done in 45.027711636s
  • PR:
snapshot untar took 78.8s
Building accounts index... Done in 38.569151364s
```<hr>This is an automatic backport of pull request #10790 done by [Mergify](https://mergify.com).

…t flag (#10790)

(cherry picked from commit 66d1057)

# Conflicts:
#	ledger-tool/src/args.rs
@mergify mergify Bot requested a review from a team as a code owner March 10, 2026 06:57
@mergify mergify Bot added the conflicts label Mar 10, 2026
@mergify mergify Bot added the conflicts label Mar 10, 2026
@mergify
Copy link
Copy Markdown
Author

mergify Bot commented Mar 10, 2026

Cherry-pick of 66d1057 has failed:

On branch mergify/bp/v4.0/pr-10790
Your branch is up to date with 'origin/v4.0'.

You are currently cherry-picking commit 66d105723.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   CHANGELOG.md
	modified:   validator/src/commands/run/args.rs
	modified:   validator/src/commands/run/execute.rs

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   ledger-tool/src/args.rs

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@kskalski kskalski marked this pull request as draft March 10, 2026 07:14
@kskalski
Copy link
Copy Markdown

There is a conflict at the moment, I think it will go away after #11122 is merged and this one rebased on top

@kskalski
Copy link
Copy Markdown

@Mergifyio rebase

@mergify
Copy link
Copy Markdown
Author

mergify Bot commented Mar 11, 2026

rebase

❌ Unable to rebase: Mergify can't impersonate kskalski

Details

User kskalski used as bot_account is unknown. Please make sure {login} exists and has logged into the Mergify dashboard.

@kskalski
Copy link
Copy Markdown

@Mergifyio rebase

@mergify
Copy link
Copy Markdown
Author

mergify Bot commented Mar 11, 2026

rebase

🛑 The pull request rule doesn't match anymore

Details

This action has been cancelled.

@kskalski
Copy link
Copy Markdown

@Mergifyio update

@mergify
Copy link
Copy Markdown
Author

mergify Bot commented Mar 11, 2026

update

✅ Branch has been successfully updated

@kskalski
Copy link
Copy Markdown

Hm, it conflicts now because 4.0 doesn't have #11005

@steviez
Copy link
Copy Markdown

steviez commented Mar 11, 2026

Hm, it conflicts now because 4.0 doesn't have #11005

I think it is probably ok to resolve the conflict manually in this case instead of BP'ing #11005 as well

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 11, 2026

Codecov Report

❌ Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 83.0%. Comparing base (e4a465e) to head (87282e5).
⚠️ Report is 3 commits behind head on v4.0.

Additional details and impacted files
@@            Coverage Diff            @@
##             v4.0   #11153     +/-   ##
=========================================
- Coverage    83.0%    83.0%   -0.1%     
=========================================
  Files         838      838             
  Lines      316545   316555     +10     
=========================================
- Hits       262875   262869      -6     
- Misses      53670    53686     +16     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kskalski kskalski marked this pull request as ready for review March 11, 2026 23:56
@kskalski kskalski requested a review from brooksprumo March 11, 2026 23:56
@kskalski kskalski merged commit 771fdaf into v4.0 Mar 12, 2026
50 checks passed
@kskalski kskalski deleted the mergify/bp/v4.0/pr-10790 branch March 12, 2026 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants