v4.0: feat: enable direct-io in accounts-db snapshot operations with opt-out flag (backport of #10790)#11153
Conversation
|
Cherry-pick of 66d1057 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
|
There is a conflict at the moment, I think it will go away after #11122 is merged and this one rebased on top |
|
@Mergifyio rebase |
❌ Unable to rebase: Mergify can't impersonate
|
|
@Mergifyio rebase |
🛑 The pull request rule doesn't match anymoreDetailsThis action has been cancelled. |
|
@Mergifyio update |
✅ Branch has been successfully updated |
|
Hm, it conflicts now because 4.0 doesn't have #11005 |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## v4.0 #11153 +/- ##
=========================================
- Coverage 83.0% 83.0% -0.1%
=========================================
Files 838 838
Lines 316545 316555 +10
=========================================
- Hits 262875 262869 -6
- Misses 53670 53686 +16 🚀 New features to boost your workflow:
|
Problem
#10507 added support to enable direct-io for snapshot operations (currently applied to unpacking accounts-db storage files) by config field.
It's enabled for tests, we want to enable it for validator and ledger-tool with an opt-out flag in case given file-system doesn't properly support direct-io.
Summary of Changes
Add a
validatorandledger-toolflag to control enabling direct-io for snapshot related operations. It is enabled by default, since in the tests it yields overall better startup / ledger-tool run time.Performance impact