feat(io_uring): generic access to context and push for Ring and Completion

[kskalski]

Problem

Ring and Completion expose similar access functions for context and allowing to push new operations. Sometimes there is client code that should execute the same logic irrespective of operation on Ring or Completion, so there should be a way to generalize access.

Summary of Changes

Introduce trait encapsulating context accessors and push.

Note: moving the functions to trait breaks existing code requiring import of the trait, so I'm open to alternative approaches:

• make trait functions distinct and just call existing functions on Ring and Completion
• skip using traits, introduce variant catching &mut Ring or &mut Completion for the rare case of having generic code using either of them

[kskalski]

Alternative approach using enum is included in #9856

[kskalski]

@alessandrod you mentioned the trait approach is preferable. I suppose RingAcccess is a good enough name for that, but I'm open to suggestions.
I rebased and updated the PR, I this this is a fine separate refactoring as is then.

[codecov-commenter]

Codecov Report

❌ Patch coverage is 89.18919% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.0%. Comparing base (e9dfcfd) to head (8edc156).

Additional details and impacted files

@@            Coverage Diff            @@
##           master   #10071     +/-   ##
=========================================
- Coverage    83.0%    83.0%   -0.1%     
=========================================
  Files         849      849             
  Lines      318266   318253     -13     
=========================================
- Hits       264364   264351     -13     
  Misses      53902    53902             

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[vadorovsky]

I'm in favor of that! I was about to nitpick #9856, that I would prefer a trait over a local enum. The name is good enough for me.

[vadorovsky]

[kskalski]

Thanks, I will proceed with merging, if we want a different name, we can always update later.