Add lab 9 - JSON Puppies #667
Conversation
alextmz
requested review from
anzboi,
anzdaddy,
camscale,
joshcarp,
juliaogris,
linuxmonk,
pentaphobe,
rokane and
samuong
as code owners
Codecov Report
@@ Coverage Diff @@
## master #667 +/- ##
======================================
Coverage 100% 100%
======================================
Files 285 289 +4
Lines 5899 6057 +158
======================================
+ Hits 5899 6057 +158
Continue to review full report at Codecov.
|
| } | ||
| } | ||
|
|
||
| func TestUnmarshall(t *testing.T) { |
There was a problem hiding this comment.
usually we don't test third party / std libraries. json.Unmarshal & json.Marshal work.
There was a problem hiding this comment.
I don't get this one - agree that it doesn't make much sense but it's a requirement from Lab 9, unless I interpreted it wrong.
| t.Run(name, func(t *testing.T) { | ||
| got, err := json.Marshal(test.obj) | ||
| assert.NoError(t, err) | ||
| assert.JSONEq(t, test.jsn, string(got)) |
There was a problem hiding this comment.
usually we don't test third party / std libraries. json.Unmarshal & json.Marshal with the correct json tags in the struct definition are well tested and work. There is no need for you to roll your own JSONstr method IMO.
There was a problem hiding this comment.
About the json.Marshall and Unmarshal, see above.
For the JSONstr, I made it a lambda instead - having a custom formatter allows me to keep all the fixtures in one place instead of duplicating them all over. Is this bad?
| var p Puppy | ||
| err := json.Unmarshal([]byte(test.jsn), &p) | ||
| assert.NoError(t, err) | ||
| assert.JSONEq(t, jsonstr(test.obj), jsonstr(test.obj)) |
There was a problem hiding this comment.
wanted and got are the same: jsonstr(test.obj)
To test Unmarshal it should probably be something like:
var p Puppy
err := json.Unmarshal([]byte(test.jsn), &p)
assert.NoError(t, err)
assert.Equal(t, test.obj, p)And yes, you are right, this is a lab requirements.
What a stupid requirement. Who wrote them? Oh yes that was me.... NVM :)
There was a problem hiding this comment.
Woops, indeed that won't test much :)
D'oh, I was thinking of assert.Equal as 'taking strings' and not 'taking interfaces'... 🤦♂️
Both fixed.
|
|
||
| type typetest map[string]struct { | ||
| obj Puppy | ||
| jsn string |
There was a problem hiding this comment.
sorry, I should have picked up on this earlier.
I'd probably rename this type as:
type testcases map[string]struct {
puppy Puppy
puppyJSON string
}
There was a problem hiding this comment.
almost there...
re commit messages:
https://github.com/anz-bank/go-course/wiki/Lab-1:-Collected-Code-Review-Comments#commit-messages
Commit messages
https://chris.beams.io/posts/git-commit/
Use git rebase -i COMMIT-HASH to rework your commits
- Separate subject from body with a blank line
- Limit the subject line to 60 characters
- Use the imperative mood in the subject line
- Do not end the subject line with a period
- Wrap the body at 80 characters
- Use the body to explain what and why vs. how
E.g. Change
Lab 1 completed.
Built fib code to binary
to
Complete Lab 1
Build fib code to binary
|
The go-course is now closed. Thank you very much for participating. |
Fixes #666 (nice number)
Review of colleague's PR #489
Changes proposed in this PR: