-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete packages request reports 200 but no package deleted #93
Comments
Updated The result is 200 but no packages are removed - the runtime result is
|
I will check your tests a bit later. Is there any way to run all of them at once? FYI: I've cleaned up the database. |
What do you mean ? If the tests were run all at once the files would be removed by the last test - you wouldn have any means verifying if the result is as expected. That said - I could create a bash script which run a sequence - possibly a to continue - would that do? |
Aren't these independent unit tests that you can run in a pipeline? |
Not yet. They are intended to be independent units at some point - right now the individual file is a PoC on how the query is formatted, the content and the endpoint reponse. My idea is - at some point - to query the target section to validate the response - but for now - even with a success response - and nothing happening - so the test is a success the result is not. |
I have no idea what happens when the request leaves my system. I have always had a mixed relation ship with forms. With my work I only use a form when forced to - luckily have yet been able to fence it off - it will come to me eventually when the admin will require a document upload function - until know I have been able to satisfy their need using an internal ftp service. I am getting timout on every request I try to make.
I upload the packages manually using the webui (not postman or similar)
|
I have tested so many methods to supply the form in an accepted format. I managed to do it in Postman so technically it is working
When I post the same form using Python - apart from some obvious elements the multipart/form-data look right to me (replaced
Perhaps you can provide some feedback on this |
I have begun tagging the requests with a custom header This is done in an attempt to track down why I cannot get the endpoint to accept a delete request using Python. I am hoping you can provide some details on how the request behave on your end because it times out.
|
I am not sure if this has any meaning or it is just grasp into thin air - it may simply be about presentation - which is more down the alley of postman than my print statements in python When I submit using Postman the field name appears without quotes Why is the post disappearing? That is why I added the x-bxtctl-token header - I don't not get any response when posting using Python. I think that understanding this is the key to the other commit |
Is there anything - literally anything that would filter requests to API. It is insanely strange that some requests passthrough and some does not. I can send a form with a single package to the endpoint - which gets accepted. Sending the same (not the exact same - that gives) request with a different package using python scripting - times out - no answer. I can send a token request using python but commits - all ends up in blackhole. One get's quite confused when some requests is accepted - others are not - with a message - and then there is the request where no clues are provided - not even 404 or 500. On eflaw - if I may be allowed to call this - is that the same endpoint /api/packages/commit takes 4 different inputs. I get it - uploading files is a special case But for the three other options it would be much simpler to parse textual inputs - instead of taking it all as form input.
Using different endpoints - the move and copy are somewhat identical - but from the point of consuming the endpoint - it makes a lot more sense
Using different endpoints will also make debugging easier - if one cannot post to one endpoint it will never affect the other(s) |
|
Sorry I was doing some maintenance and restarting bxt instance. It should be sorted out now.
Of course I thought of this idea and it makes a lot of sense at the first glance - but commits should be atomic. What happens if you'll have a network outage in between of these commands? |
Also please check Matrix, I'm having some issues with running bxtctl locally... |
The delete package transaction request now works. Perhaps it is a combination of efforts - I don't know - what I do know - it is no longer an issue |
Request for deleting the test package from the repo returns 200 OK even though the package does not exist.
The
tests/40_pkg_delete.py
from bxtctl is usedThe text was updated successfully, but these errors were encountered: