Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document folders/components #32

Open
Tracked by #65
LordTermor opened this issue May 23, 2024 · 4 comments · May be fixed by #38
Open
Tracked by #65

Document folders/components #32

LordTermor opened this issue May 23, 2024 · 4 comments · May be fixed by #38
Assignees
@LordTermor
Labels
documentation Improvements or additions to documentation

Comments

@LordTermor
Copy link
Collaborator

This project follows DDD and for better understanding/developers onboarding it makes sense to describe components it uses and add proper references
@LordTermor LordTermor added the documentation Improvements or additions to documentation label May 23, 2024
@LordTermor LordTermor self-assigned this May 23, 2024
@LordTermor LordTermor modified the milestones: Initial testing (MVP), Production May 24, 2024
@LordTermor LordTermor linked a pull request May 24, 2024 that will close this issue
Add documentation #38
Draft
@fhdk
Copy link
Collaborator

fhdk commented May 28, 2024

In model PoolEntryResponse you have two properties

version: <string>
signaturePath: <bool>

The signaturePath seem to indicate a string rather than a boolean?

@fhdk
Copy link
Collaborator

fhdk commented May 28, 2024

In LogEntryType enum you have these members

Add, Remove, Update

Does that imply that a package is never Delete?

@LordTermor
Copy link
Collaborator Author

LordTermor commented May 28, 2024 •
edited
Loading

The signaturePath seem to indicate a string rather than a boolean?

The field is "hasSignature" actually.

Does that imply that a package is never Delete?

It implies I'm not good at English and thought Delete and Remove are full synonyms. 😄

I'll correct that.

@fhdk
Copy link
Collaborator

fhdk commented May 28, 2024

CRUD is acronym for

  • Create
  • Read
  • Update
  • Delete

@LordTermor LordTermor mentioned this issue Jun 2, 2024
Open
40 tasks
@LordTermor LordTermor removed this from the Production milestone Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LordTermor LordTermor

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add documentation LordTermor/bxt
2 participants
@LordTermor @fhdk