Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update themes documentation & CI #3404

Open
3 of 6 tasks
rickstaa opened this issue Oct 22, 2023 · 3 comments
Open
3 of 6 tasks

Update themes documentation & CI #3404

rickstaa opened this issue Oct 22, 2023 · 3 comments
Assignees
Labels
ci CI related features. documentation Improvements or additions to documentation. enhancement New feature or request.

Comments

@rickstaa
Copy link
Collaborator

rickstaa commented Oct 22, 2023

Is your feature request related to a problem? Please describe.

To streamline maintenance processes, we've temporarily halted the addition of new themes (details can be found here). While this adjustment is in effect, it's crucial to effectively communicate this change to our users and update the CI accordingly.

Describe the solution you'd like

To ensure utmost transparency with this change, we propose the following steps:

Describe alternatives you've considered

No alternatives have been considered at this time.

Additional context

No additional information provided.

@rickstaa rickstaa added the enhancement New feature or request. label Oct 22, 2023
@qwerty541
Copy link
Collaborator

@rickstaa I think that it's good decision to temporary halt themes addition, since it's prevent wasting our time on a lot of spam pull requests. I only want you to review two my pull requests before (#3401 and #3400), recently i did a little work to allow users contribute gradient themes and i don't want the result of my work to be lost, since it would be userful if we're going to enable back themes addition in future.

@rickstaa
Copy link
Collaborator Author

@rickstaa I think that it's good decision to temporary halt themes addition, since it's prevent wasting our time on a lot of spam pull requests. I only want you to review two my pull requests before (#3401 and #3400), recently i did a little work to allow users contribute gradient themes and i don't want the result of my work to be lost, since it would be userful if we're going to enable back themes addition in future.

Of course! Great additions if we enable the theme contributions in the future. I merged your PRs into the main branch!

@qwerty541 qwerty541 added documentation Improvements or additions to documentation. ci CI related features. labels Oct 26, 2023
@qwerty541
Copy link
Collaborator

@rickstaa I think that it's good decision to temporary halt themes addition, since it's prevent wasting our time on a lot of spam pull requests. I only want you to review two my pull requests before (#3401 and #3400), recently i did a little work to allow users contribute gradient themes and i don't want the result of my work to be lost, since it would be userful if we're going to enable back themes addition in future.

Of course! Great additions if we enable the theme contributions in the future. I merged your PRs into the main branch!

Thanks! Looks like i made a mistake while implementing feature to allow addition of gradient themes and preview-theme workflow still fails. I have opened pull request #3427 to resolve this issue, please check it.

This was referenced Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci CI related features. documentation Improvements or additions to documentation. enhancement New feature or request.
Projects
None yet
Development

No branches or pull requests

2 participants