Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pie chart style to language card #1650

Closed
rickstaa opened this issue Mar 16, 2022 · 13 comments · Fixed by #2099
Closed

Add pie chart style to language card #1650

rickstaa opened this issue Mar 16, 2022 · 13 comments · Fixed by #2099
Assignees
Labels
enhancement New feature or request. hacktoberfest help wanted Extra attention is needed. lang-card Issues related to the language card. ⭐ top feature Top feature request.

Comments

@rickstaa
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

As discussed in #945 it would be nice to give users the ability to display their most used languages as a pie chart.

Describe the solution you'd like

pie_Chart

@rickstaa rickstaa added feature lang-card Issues related to the language card. labels Mar 16, 2022
@rickstaa rickstaa changed the title [feature request] Add pie chart style to language card Add pie chart style to language card Mar 16, 2022
@anuraghazra
Copy link
Owner

We can probably explore that, the reason we choose our current design for the card is because we wanted to make it match the design of github's native language cards.

@rickstaa
Copy link
Collaborator Author

@anuraghazra Makes sense. I opened this as a response to #945 (comment) when I was cleaning up the discussions page. Let's use this issue to check if there is enough support for this feature from the community.

@rickstaa rickstaa added enhancement New feature or request. and removed feature labels Jul 25, 2022
@sasankaweera123
Copy link

If you are able to create a pie chart card it will be great for GitHub organizations

@rickstaa
Copy link
Collaborator Author

@sasankaweera123 I currently do not have the time to implement this myself. However, since it is one of the top requested features, feel free to create a pull request and I will look at it.

@rickstaa rickstaa added the help wanted Extra attention is needed. label Sep 22, 2022
@rickstaa
Copy link
Collaborator Author

If someone wants to tackle this, https://github.com/d3/d3-shape#pies is a good package that can be used for creating pie charts. An example can be found here.

@arndom
Copy link
Contributor

arndom commented Oct 2, 2022

Hey, I would like to work on this, please assign it to me

@rickstaa
Copy link
Collaborator Author

rickstaa commented Oct 2, 2022

Great! I assigned you to the issue! 🚀

@sasankaweera123
Copy link

This Solution is great: Summary Cards

@rickstaa
Copy link
Collaborator Author

rickstaa commented Oct 2, 2022

@sasankaweera123 Good one! Summary Cards is a good code example of how this feature can be added to GRS.

@arndom
Copy link
Contributor

arndom commented Oct 2, 2022

@rickstaa is the goal to have it appear exactly as the image in the issue description?

@rickstaa
Copy link
Collaborator Author

rickstaa commented Oct 2, 2022

@arndom O no, that was a simple example draft @HPaulson made in #945. I just copied it here to explain the idea. I think the pie chart should be an option on the current language card (i.e. pie_chart=true). It should therefore be as close as possible to the current card. So something like the language card in https://github.com/vn7n24fzkq/github-profile-summary-cards with the legend to the left and the pie chart to the right. What do you think is a good design?

image

image

I found https://www.chartjs.org/docs/latest/charts/doughnut.html, which can also be used to create pie charts if the method used in https://github.com/vn7n24fzkq/github-profile-summary-cards is not sufficient.

@arndom
Copy link
Contributor

arndom commented Oct 2, 2022

oh ok, almost done, remains the position of langs...ended up using the same pkg as summary cards
image

@rickstaa
Copy link
Collaborator Author

rickstaa commented Oct 2, 2022

Great. It could also be implemented like the hide_rank option in the stats card where the card is the same, but the pie chart is added.

[![Anurag's GitHub stats](https://github-readme-stats.vercel.app/api?username=anuraghazra&show_icons=true)](https://github.com/anuraghazra/github-readme-stats)

Anurag's GitHub stats

[![Anurag's GitHub stats](https://github-readme-stats.vercel.app/api?username=anuraghazra&show_icons=true&hide_rank=true)](https://github.com/anuraghazra/github-readme-stats)

Anurag's GitHub stats

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request. hacktoberfest help wanted Extra attention is needed. lang-card Issues related to the language card. ⭐ top feature Top feature request.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants