-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug Fix] Show sub folder option not recursing through nested folders #110
Comments
Really? For me, it seems to work. It is supposed to show pictures in subfolders, but not deeper than 1st or 2nd level (don't remember), to prevent extreme situations when it tries to index the whole file system. For you, it always shows only the root directory? |
I thought it was broken because the folder structure I have for my wallpapers has a depth of 3. I did some testing on my own branch using the glob module and it performed very well. I'll try and benchmark the difference it can produce on a large set of files. How about a fully recursive option? That would allow the depth to be infinite. It would be off by default which allows the user to understand that there is a performance hit on a large set of files |
Yes, that sounds reasonable, could be one of the ticks in the menu for |
How about if the depth is a negative integer, it means that its infinite? |
Yep, and 0 would be only root folder. |
Thank you again for the PR. I also added some refinements and and called it "Show all subfolders" just to make it more obvious for the used what is being recursed. |
From what I understand, the show sub folders option is supposed to show images that are deeper than the root directory. However, it does not function as I would understand it to.
The text was updated successfully, but these errors were encountered: