Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Fix] Show sub folder option not recursing through nested folders #110

Closed
nikolaizombie1 opened this issue Dec 19, 2024 · 6 comments
Closed

Comments

@nikolaizombie1
Copy link
Contributor

From what I understand, the show sub folders option is supposed to show images that are deeper than the root directory. However, it does not function as I would understand it to.

@anufrievroman
Copy link
Owner

Really? For me, it seems to work. It is supposed to show pictures in subfolders, but not deeper than 1st or 2nd level (don't remember), to prevent extreme situations when it tries to index the whole file system. For you, it always shows only the root directory?

@nikolaizombie1
Copy link
Contributor Author

Really? For me, it seems to work. It is supposed to show pictures in subfolders, but not deeper than 1st or 2nd level (don't remember), to prevent extreme situations when it tries to index the whole file system. For you, it always shows only the root directory?

I thought it was broken because the folder structure I have for my wallpapers has a depth of 3. I did some testing on my own branch using the glob module and it performed very well. I'll try and benchmark the difference it can produce on a large set of files.

How about a fully recursive option? That would allow the depth to be infinite. It would be off by default which allows the user to understand that there is a performance hit on a large set of files

@anufrievroman
Copy link
Owner

Yes, that sounds reasonable, could be one of the ticks in the menu for Infinite subfolders, or an option in the config file, like subfolder_depth = 10 for example.

@nikolaizombie1
Copy link
Contributor Author

Yes, that sounds reasonable, could be one of the ticks in the menu for Infinite subfolders, or an option in the config file, like subfolder_depth = 10 for example.

How about if the depth is a negative integer, it means that its infinite?

@anufrievroman
Copy link
Owner

Yep, and 0 would be only root folder.

@anufrievroman
Copy link
Owner

Thank you again for the PR. I also added some refinements and and called it "Show all subfolders" just to make it more obvious for the used what is being recursed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants