-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(resize): add resize active options, close #855 #864
Conversation
🎊 PR Preview has been successfully built and deployed to https://s2-preview-pr-864.surge.sh |
Size Change: -33 B (0%) Total Size: 185 kB
ℹ️ View Unchanged
|
补充一下基础交互 https://s2.antv.vision/zh/docs/manual/advanced/interaction/basic 和 API 文档 |
This pull request introduces 1 alert when merging 5d1f7ad into c49fa9f - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging 8686fd1 into c49fa9f - view on LGTM.com new alerts:
|
Codecov Report
@@ Coverage Diff @@
## master #864 +/- ##
==========================================
- Coverage 71.44% 71.44% -0.01%
==========================================
Files 168 168
Lines 11771 11779 +8
Branches 2751 2755 +4
==========================================
+ Hits 8410 8415 +5
Misses 2206 2206
- Partials 1155 1158 +3
Continue to review full report at Codecov.
|
packages/s2-core/__tests__/spreadsheet/spread-sheet-resize-spec.ts
Outdated
Show resolved
Hide resolved
packages/s2-core/__tests__/spreadsheet/spread-sheet-resize-spec.ts
Outdated
Show resolved
Hide resolved
https://s2.antv.vision/zh/docs/manual/advanced/interaction/basic 补充下交互相关配置吧, 顺便去掉一下这个 【点击查看详情】感觉不是很明显 直接放开吧 如果可以的话,建议在加一个 resize 的 demo :) |
This pull request introduces 1 alert when merging 79236cc into c49fa9f - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging b0a51ef into c49fa9f - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging 63d821c into c49fa9f - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging 73c2e10 into c49fa9f - view on LGTM.com new alerts:
|
🎉 This PR is included in version @antv/s2-v1.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version @antv/s2-react-v1.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
* feat: add resize active options * test: update test * refactor: add resize config for playground * refactor: simplify resize config * refactor: update playground * test: update default options * test: fix unit test * docs: add resize docs * docs: fix type declaration style issue * docs: remove api summary * docs: refine resize demo
👀 PR includes
✨ Feature
🎨 Enhance
🐛 Bugfix
🔧 Chore
📝 Description
🖼️ Screenshot
🔗 Related issue link
close #855
🔍 Self Check before Merge