Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(resize): add resize active options, close #855 #864

Merged
merged 12 commits into from
Dec 6, 2021

Conversation

wjgogogo
Copy link
Contributor

@wjgogogo wjgogogo commented Dec 3, 2021

👀 PR includes

✨ Feature

  • 增加resize热区active配置项
  • 增加 playground resize 配置

🎨 Enhance

  • Code style optimization
  • Refactoring
  • Change the UI
  • Improve the performance
  • Type optimization

🐛 Bugfix

🔧 Chore

  • Test case
  • Docs / demos update
  • CI / workflow
  • Release version
  • Other ()

📝 Description

🖼️ Screenshot

image
2021-12-03 20 39 10

🔗 Related issue link

close #855

🔍 Self Check before Merge

  • Add or update relevant Docs.
  • Add or update relevant Demos.
  • Add or update relevant TypeScript definitions.

@github-actions github-actions bot added the pr(feature) new feature label Dec 3, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2021

🎊 PR Preview has been successfully built and deployed to https://s2-preview-pr-864.surge.sh

@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2021

Size Change: -33 B (0%)

Total Size: 185 kB

Filename Size Change
./packages/s2-core/dist/index.min.js 113 kB -33 B (0%)
ℹ️ View Unchanged
Filename Size
./packages/s2-core/dist/style.min.css 356 B
./packages/s2-react/dist/index.min.js 68.6 kB
./packages/s2-react/dist/style.min.css 3.1 kB

compressed-size-action

@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2021

你好, @wjgogogo CI 执行失败, 请点击 [Details] 按钮查看, 并根据日志修复。

Hello, @wjgogogo CI run failed, please click the [Details] button try to fixed it.

@github-actions github-actions bot added the 🚨 test failed 单元测试挂了 label Dec 3, 2021
@lijinke666
Copy link
Member

补充一下基础交互 https://s2.antv.vision/zh/docs/manual/advanced/interaction/basic 和 API 文档

@lgtm-com
Copy link

lgtm-com bot commented Dec 3, 2021

This pull request introduces 1 alert when merging 5d1f7ad into c49fa9f - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Dec 3, 2021

This pull request introduces 1 alert when merging 8686fd1 into c49fa9f - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@github-actions github-actions bot removed the 🚨 test failed 单元测试挂了 label Dec 3, 2021
@codecov
Copy link

codecov bot commented Dec 3, 2021

Codecov Report

Merging #864 (0c0190e) into master (9e411b5) will decrease coverage by 0.00%.
The diff coverage is 90.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #864      +/-   ##
==========================================
- Coverage   71.44%   71.44%   -0.01%     
==========================================
  Files         168      168              
  Lines       11771    11779       +8     
  Branches     2751     2755       +4     
==========================================
+ Hits         8410     8415       +5     
  Misses       2206     2206              
- Partials     1155     1158       +3     
Impacted Files Coverage Δ
packages/s2-core/src/common/constant/options.ts 100.00% <ø> (ø)
packages/s2-core/src/cell/base-cell.ts 76.92% <75.00%> (-0.06%) ⬇️
packages/s2-core/src/cell/col-cell.ts 76.27% <100.00%> (-0.31%) ⬇️
packages/s2-core/src/cell/corner-cell.ts 70.49% <100.00%> (-0.23%) ⬇️
packages/s2-core/src/cell/row-cell.ts 72.05% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e411b5...0c0190e. Read the comment docs.

@lijinke666
Copy link
Member

https://s2.antv.vision/zh/docs/manual/advanced/interaction/basic 补充下交互相关配置吧, 顺便去掉一下这个 【点击查看详情】感觉不是很明显 直接放开吧
image

如果可以的话,建议在加一个 resize 的 demo :)

@lgtm-com
Copy link

lgtm-com bot commented Dec 6, 2021

This pull request introduces 1 alert when merging 79236cc into c49fa9f - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Dec 6, 2021

This pull request introduces 1 alert when merging b0a51ef into c49fa9f - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Dec 6, 2021

This pull request introduces 1 alert when merging 63d821c into c49fa9f - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Dec 6, 2021

This pull request introduces 1 alert when merging 73c2e10 into c49fa9f - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

xingwanying
xingwanying previously approved these changes Dec 6, 2021
@lijinke666 lijinke666 merged commit 1ce0951 into master Dec 6, 2021
@lijinke666 lijinke666 deleted the feat-resize-option branch December 6, 2021 08:18
@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2021

🎉 This PR is included in version @antv/s2-v1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2021

🎉 This PR is included in version @antv/s2-react-v1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

wjgogogo added a commit that referenced this pull request Oct 25, 2023
* feat: add resize active options

* test: update test

* refactor: add resize config for playground

* refactor: simplify resize config

* refactor: update playground

* test: update default options

* test: fix unit test

* docs: add resize docs

* docs: fix type declaration style issue

* docs: remove api summary

* docs: refine resize demo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🤔能否禁用调整行高
3 participants