-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tooltip): enhance tooltip #862
Conversation
🎊 PR Preview has been successfully built and deployed to https://s2-preview-pr-862.surge.sh |
Size Change: +104 B (0%) Total Size: 185 kB
ℹ️ View Unchanged
|
你好, @lijinke666 CI 执行失败, 请点击 [Details] 按钮查看, 并根据日志修复。 Hello, @lijinke666 CI run failed, please click the [Details] button try to fixed it. |
Codecov Report
@@ Coverage Diff @@
## master #862 +/- ##
==========================================
+ Coverage 71.13% 71.81% +0.68%
==========================================
Files 168 170 +2
Lines 11654 12561 +907
Branches 2729 3047 +318
==========================================
+ Hits 8290 9021 +731
- Misses 2220 2318 +98
- Partials 1144 1222 +78
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG
🎉 This PR is included in version @antv/s2-v1.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version @antv/s2-react-v1.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
* feat(tooltip): enhance tooltip * feat(tooltip): update docs * feat(tooltip): fix test * feat(tooltip): fix test * feat(tooltip): fix test * feat(tooltip): update docs * feat(tooltip): update demo * feat(tooltip): update docs * feat(tooltip): support config corner and rename cell => data * feat(tooltip): update docs
👀 PR includes
✨ Feature
🐛 Bugfix
📝 Description
corner
配置, tooltip.cell 重命名为tooltip.data
, 保持和内部单元格命名一致, 避免歧义onRowCellHover
canvas
的事件没有注销, 取消组件层的unBindEvent
修改为core
层统一注销tooltip
时, 点击鼠标右键出现浏览器菜单后, 误判为刷选模式hoverFocusTimer
800ms 的计时器, 导致 有几率关闭tooltip
后再次出现的问题content
控制台警告 (重复的key)BaseCell
基础类 API🖼️ Screenshot
🔗 Related issue link
close #852
🔍 Self Check before Merge