-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: only omit undefined row cell #861
Conversation
🎊 PR Preview has been successfully built and deployed to https://s2-preview-pr-861.surge.sh |
Size Change: +11 B (0%) Total Size: 184 kB
ℹ️ View Unchanged
|
Codecov Report
@@ Coverage Diff @@
## master #861 +/- ##
==========================================
+ Coverage 71.13% 71.14% +0.01%
==========================================
Files 168 168
Lines 11654 11656 +2
Branches 2729 2728 -1
==========================================
+ Hits 8290 8293 +3
Misses 2220 2220
+ Partials 1144 1143 -1
Continue to review full report at Codecov.
|
🎉 This PR is included in version @antv/s2-v1.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
* fix: only omit undefined values * test: add unit test for empty string field * test: add null and undefined test data
👀 PR includes
✨ Feature
🎨 Enhance
🐛 Bugfix
🔧 Chore
📝 Description
🖼️ Screenshot
🔗 Related issue link
close #860
🔍 Self Check before Merge