Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only omit undefined row cell #861

Merged
merged 3 commits into from
Dec 3, 2021
Merged

Conversation

wjgogogo
Copy link
Contributor

@wjgogogo wjgogogo commented Dec 3, 2021

👀 PR includes

✨ Feature

  • New feature

🎨 Enhance

  • Code style optimization
  • Refactoring
  • Change the UI
  • Improve the performance
  • Type optimization

🐛 Bugfix

🔧 Chore

  • Test case
  • Docs / demos update
  • CI / workflow
  • Release version
  • Other ()

📝 Description

🖼️ Screenshot

Before After

🔗 Related issue link

close #860

🔍 Self Check before Merge

  • Add or update relevant Docs.
  • Add or update relevant Demos.
  • Add or update relevant TypeScript definitions.

@github-actions github-actions bot added the pr(fix) bug fix label Dec 3, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2021

🎊 PR Preview has been successfully built and deployed to https://s2-preview-pr-861.surge.sh

@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2021

Size Change: +11 B (0%)

Total Size: 184 kB

Filename Size Change
./packages/s2-core/dist/index.min.js 113 kB +11 B (0%)
ℹ️ View Unchanged
Filename Size
./packages/s2-core/dist/style.min.css 356 B
./packages/s2-react/dist/index.min.js 68.5 kB
./packages/s2-react/dist/style.min.css 3.1 kB

compressed-size-action

@codecov
Copy link

codecov bot commented Dec 3, 2021

Codecov Report

Merging #861 (6f4767d) into master (025ec55) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #861      +/-   ##
==========================================
+ Coverage   71.13%   71.14%   +0.01%     
==========================================
  Files         168      168              
  Lines       11654    11656       +2     
  Branches     2729     2728       -1     
==========================================
+ Hits         8290     8293       +3     
  Misses       2220     2220              
+ Partials     1144     1143       -1     
Impacted Files Coverage Δ
...s/s2-core/src/facet/layout/build-gird-hierarchy.ts 82.75% <100.00%> (+2.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 025ec55...6f4767d. Read the comment docs.

@lijinke666 lijinke666 merged commit 9386688 into master Dec 3, 2021
@lijinke666 lijinke666 deleted the fix-undefind-row-cell branch December 3, 2021 05:53
@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2021

🎉 This PR is included in version @antv/s2-v1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

wjgogogo added a commit that referenced this pull request Oct 25, 2023
* fix: only omit undefined values

* test: add unit test for empty string field

* test: add null and undefined test data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 行头包含空数据字段时显示不正常
2 participants