-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cell): border width issue #859
Conversation
🎊 PR Preview has been successfully built and deployed to https://s2-preview-pr-859.surge.sh |
This pull request introduces 2 alerts when merging c2262e9 into 025ec55 - view on LGTM.com new alerts:
|
Size Change: +327 B (0%) Total Size: 185 kB
ℹ️ View Unchanged
|
Codecov Report
@@ Coverage Diff @@
## master #859 +/- ##
==========================================
+ Coverage 71.26% 71.65% +0.39%
==========================================
Files 167 169 +2
Lines 11574 11766 +192
Branches 2708 2750 +42
==========================================
+ Hits 8248 8431 +183
- Misses 2184 2185 +1
- Partials 1142 1150 +8
Continue to review full report at Codecov.
|
This pull request introduces 2 alerts when merging 7dc1adb into 025ec55 - view on LGTM.com new alerts:
|
This pull request introduces 2 alerts when merging 6ee4411 into 025ec55 - view on LGTM.com new alerts:
|
This pull request introduces 2 alerts when merging d6b3b08 into 025ec55 - view on LGTM.com new alerts:
|
🎉 This PR is included in version @antv/s2-v1.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version @antv/s2-react-v1.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
* fix: data cell border * fix: data cell border issue * feat: update test spec * refactor: border draw call into one method * refactor: series number node border * fix: tree hierachy border * refactor: combine border draw call * feat: replace cell border * feat: replace cell border * feat: replace cell border
👀 PR includes
📝 Description
修复了 data cell 边框渲染的粗细不一的问题。
顺便对 col/row/corner 的边框渲染逻辑做了抽取和统一。统一使用 getBorderPositionAndStyle 绘制。
🖼️ Screenshot
🔗 Related issue link
close #426