Upgrade go.uber.org/mock/mockgen to v0.4.0 #6477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should be merged after #6481 |
The version of the mockgen binary included in the codegen image should match the version of the go.uber.org/mock module that we use. There was a small change in formatting of generated files (extra empty line), which is why all generated mock files are updated as part of this PR... Signed-off-by: Antonin Bas <[email protected]>
antoninbas
force-pushed
the
upgrade-go.uber.org/mock/mockgen-to-v0.4.0
branch
from
225ed30
to
8f81a45
Compare
tnqn
approved these changes
Jun 26, 2024
antoninbas
added a commit
to antoninbas/antrea
that referenced
this pull request
Jun 26, 2024
PRs antrea-io#6447 and antrea-io#6477 got merged around the same time, and the mock file for the BGP interface was not generated using the latest mockgen version. Signed-off-by: Antonin Bas <[email protected]>
antoninbas
added a commit
that referenced
this pull request
Jun 27, 2024
PRs #6447 and #6477 got merged around the same time, and the mock file for the BGP interface was not generated using the latest mockgen version. Signed-off-by: Antonin Bas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version of the mockgen binary included in the codegen image should match the version of the go.uber.org/mock module that we use.
There was a small change in formatting of generated files (extra empty line), which is why all generated mock files are updated as part of this PR...