-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promote feature CleanupStaleUDPSvcConntrack from Alpha to Beta #6372
Conversation
2159797
to
50c73bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we planning to bump this up to GA for v2.2?
With the current state of things, is there any situation where a user would want to be able to disable this functionality?
(You may to update some unit tests with this change)
I think we can do it in v2.2. After all, this is a basic functionality. It was not supposed to add a feature gate when adding this. However, due to the limitation of
Maybe there is no reason to disable the functionality since it is a very basic. You can find the corresponding e2e tests in this link https://raw.githubusercontent.com/kubernetes/kubernetes/master/test/e2e/network/conntrack.go.
Yes, I'll add or update some unit tests to cover all code of the functionality. |
24a3f0c
to
a6fc051
Compare
I see you already extracted virtualNodeIP related cleanup to #6379, which is the right thing. The PR should just focus on the promotion. |
a6fc051
to
3044aff
Compare
3044aff
to
9b82e7b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we extract the refactoring of pkg/agent/proxy/proxier_test.go from this graduation PR? Are the 2 changes inter-dependent?
Will do.
No, the refactoring of pkg/agent/proxy/proxier_test.go could be dependent. Though my original motivation for refactoring the file is to enable CleanupStaleUDPSvcConntrack in some tests. |
9b82e7b
to
a1f9f7f
Compare
In antrea-io#5112, due to the limitations of the Go netlink library, AntreaProxy would unconditionally delete conntrack entries added by kube-proxy in conntrack zone 0. AntreaProxy was supposed to only delete its own entries in conntrack zones 65520 or 65521. To address this, a feature was added to isolate the relevant code. After the merge of antrea-io#6193, the netlink library was updated, allowing AntreaProxy to precisely delete conntrack entries in zones 65520 or 65521. It is now safe to enable the corresponding code by default. Signed-off-by: Hongliang Liu <[email protected]>
a1f9f7f
to
8bdc2b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/test-all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
In #5112, due to the limitations of the Go netlink library, AntreaProxy
would unconditionally delete conntrack entries added by kube-proxy in
conntrack zone 0. AntreaProxy was supposed to only delete its own entries
in conntrack zones 65520 or 65521. To address this, a feature was added
to isolate the relevant code.
After the merge of #6193, the netlink library was updated, allowing
AntreaProxy to precisely delete conntrack entries in zones 65520 or 65521.
It is now safe to enable the corresponding code by default.
Depends on #6379