Trim images in Node objects to reduce memory footprint #6351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The images field is of no use to Antrea while it could be a long list and take quite some space as antrea-controller and all antrea-agent instances cache all Nodes in the cluster. Trimming images can release nearly 10m memory from each Antrea process in a cluster of 1k Nodes, saving 10G memory in total. Signed-off-by: Quan Tian <[email protected]>
tnqn
added
the
kind/cleanup
|
/test-all |
antoninbas
approved these changes
May 21, 2024
| if !ok { | ||
| return obj, nil | ||
| } | ||
| node.Status.Images = nil |
There was a problem hiding this comment.
is node.Status.NodeInfo safe to remove as well?
is it insignificant compared to node.Status.Images?
There was a problem hiding this comment.
It's safe to remove it. However, the field is not a pointer but a struct containing 10 strings, while each string is not too long. To trim them, the simplest code is to override it with a new struct, which could increase heap usage 160 bytes per object temporarily, whille overriding one field per line seems not very worth as each field is not long: the total data size in a typical nodeInfo is about 200 bytes.
nodeInfo:
architecture: amd64
bootID: 56ae4e38-a8b1-4657-8b8a-86a75623926e
containerRuntimeVersion: containerd://1.7.15
kernelVersion: 5.4.0-169-generic
kubeProxyVersion: v1.30.0
kubeletVersion: v1.30.0
machineID: d61012698a3649178b7f74d6f57fc965
operatingSystem: linux
osImage: Debian GNU/Linux 12 (bookworm)
systemUUID: d43097b6-a686-420f-b033-fd5c15392e4d
There was a problem hiding this comment.
Good point, thanks for the detailed answer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The images field is of no use to Antrea while it could be a long list and take quite some space as antrea-controller and all antrea-agent instances cache all Nodes in the cluster.
Trimming images can release nearly 10m memory from each Antrea process in a cluster of 1k Nodes, saving 10G memory in total.