Support simple ping mesh in agent. #6120

IRONICBo · 2024-03-19T08:21:03Z

We need to implement a simple ping-mesh monitoring tool to get nodes connectivity latency.

Design doc(TODO): https://docs.google.com/document/d/1EdKJ8iQ3KwVBQAHaPisqHP7cgpq4RW8mD9KPWtYETbE

Issue: #5514

cmd/antrea-agent/agent.go

pkg/agent/monitortool/latency_store.go

go.mod

pkg/agent/monitortool/monitor.go

pkg/agent/monitortool/latency_store.go

pkg/config/agent/config.go

pkg/features/antrea_features.go

pkg/agent/monitortool/monitor.go

go.mod

pkg/agent/monitortool/monitor.go

IRONICBo · 2024-04-08T19:23:02Z

support to get gw0/podCIDR from node spec.
support singleton CRD in nodelatencymonitor.

Maybe I need to consider about the NetworkPolicyOnly mode by using Transport Address, now only support get IP from first CIDR IP.

I0408 19:16:11.801016       1 monitor.go:249] "Connection status" Connection={"FromIP":"10.244.2.1","ToIP":"10.244.0.1","Latency":0,"Status":false,"LastUpdated":"2024-04-08T19:16:11.800804713Z","CreatedAt":"0001-01-01T00:00:00Z"}
I0408 19:16:11.801040       1 monitor.go:249] "Connection status" Connection={"FromIP":"10.244.2.1","ToIP":"10.244.2.1","Latency":97881,"Status":true,"LastUpdated":"2024-04-08T19:16:11.80070513Z","CreatedAt":"0001-01-01T00:00:00Z"}
I0408 19:16:11.801057       1 monitor.go:249] "Connection status" Connection={"FromIP":"10.244.2.1","ToIP":"10.244.1.1","Latency":0,"Status":false,"LastUpdated":"2024-04-08T19:16:11.800928351Z","CreatedAt":"0001-01-01T00:00:00Z"}

build/charts/antrea/crds/nodelatencymonitor.yaml

pkg/agent/monitortool/latency_store.go

pkg/agent/monitortool/monitor.go

pkg/agent/monitortool/latency_store_test.go

pkg/agent/monitortool/latency_store.go

pkg/agent/monitortool/monitor.go

cmd/antrea-agent/agent.go

pkg/agent/monitortool/latency_store.go

pkg/agent/monitortool/latency_store_test.go

pkg/agent/monitortool/latency_store.go

pkg/agent/monitortool/latency_store_test.go

pkg/agent/monitortool/monitor.go

pkg/apis/crd/v1alpha2/types.go

pkg/agent/monitortool/latency_store.go

pkg/agent/monitortool/monitor.go

pkg/agent/monitortool/latency_store.go

IRONICBo · 2024-04-15T18:09:52Z

I will update my code later.

pkg/agent/monitortool/latency_store.go

pkg/agent/monitortool/monitor.go

pkg/apis/crd/v1alpha2/types.go

pkg/agent/monitortool/monitor.go

pkg/apis/crd/v1alpha2/types.go

pkg/apis/controlplane/types.go

pkg/features/antrea_features.go

pkg/agent/monitortool/latency_store.go

pkg/agent/monitortool/monitor.go

build/charts/antrea/crds/nodelatencymonitor.yaml

heanlan · 2024-04-24T21:48:25Z

Hi @antoninbas , do you know why the codecov bot is not running for this PR? @IRONICBo was asking about the codecov requirements for merging a PR

antoninbas · 2024-04-24T22:23:22Z

Hi @antoninbas , do you know why the codecov bot is not running for this PR? @IRONICBo was asking about the codecov requirements for merging a PR

I don't think there has been a successful CI run yet?
For example currently, even unit tests are failing.

pkg/agent/monitortool/monitor.go

antoninbas

LGTM
@IRONICBo thanks for your contribution and for bearing with us through all these rounds of reviews. Please open your follow up PR with the reporting changes once this is merged.

IRONICBo · 2024-05-30T00:08:24Z

Thanks for your careful review, and I will subsequently open follow-ups subsequent PRs for monitor tool.

Signed-off-by: IRONICBo <[email protected]>

Signed-off-by: Asklv <[email protected]>

antoninbas · 2024-05-30T21:40:09Z

/test-all

Follow up to #6120 See #5514 Signed-off-by: Asklv <[email protected]>

IRONICBo changed the title ~~feat: support simple ping mesh in agent.~~ Support simple ping mesh in agent. Mar 19, 2024

This comment was marked as outdated.

Sign in to view

antoninbas reviewed Mar 19, 2024

View reviewed changes

IRONICBo commented Mar 21, 2024

View reviewed changes

pkg/agent/monitortool/latency_store.go Outdated Show resolved Hide resolved

antoninbas reviewed Mar 28, 2024

View reviewed changes

This comment was marked as resolved.

Sign in to view

IRONICBo requested review from antoninbas and Dyanngg April 8, 2024 17:08

Dyanngg reviewed Apr 8, 2024

View reviewed changes

IRONICBo force-pushed the 5514-ping-mesh-monitoring-tool branch from 310d69b to b866203 Compare April 9, 2024 06:25

IRONICBo requested a review from Dyanngg April 9, 2024 18:47

heanlan reviewed Apr 10, 2024

View reviewed changes

Dyanngg reviewed Apr 10, 2024

View reviewed changes

antoninbas reviewed Apr 10, 2024

View reviewed changes

IRONICBo requested review from antoninbas, Dyanngg and heanlan April 17, 2024 17:44

Dyanngg reviewed Apr 17, 2024

View reviewed changes

antoninbas reviewed Apr 18, 2024

View reviewed changes

This comment was marked as spam.

Sign in to view

IRONICBo force-pushed the 5514-ping-mesh-monitoring-tool branch from f6c7714 to 6915393 Compare April 22, 2024 18:19

antoninbas reviewed Apr 23, 2024

View reviewed changes

IRONICBo commented Apr 25, 2024

View reviewed changes

pkg/agent/monitortool/monitor.go Outdated Show resolved Hide resolved

IRONICBo force-pushed the 5514-ping-mesh-monitoring-tool branch 2 times, most recently from cea5be0 to 3c1cfef Compare April 27, 2024 00:53

IRONICBo mentioned this pull request May 1, 2024

Export node latency query api. #6279

Closed

antoninbas approved these changes May 29, 2024

View reviewed changes

IRONICBo added 18 commits May 30, 2024 14:38

support simple ping mesh in agent

3a1d410

Signed-off-by: IRONICBo <[email protected]>

feat: update feature config and ping tool.

7993ffc

Signed-off-by: IRONICBo <[email protected]>

feat: add singleton nodelatencymonitor crd define.

048dbdd

Signed-off-by: IRONICBo <[email protected]>

feat: watch nodelatencymonitor crd to start or stop monitor.

6f711ad

Signed-off-by: IRONICBo <[email protected]>

feat: support get pod gw0 ip.

1abd59e

Signed-off-by: IRONICBo <[email protected]>

feat: support NetworkPolicyOnly and fix dual stack IPs.

77b996d

Signed-off-by: IRONICBo <[email protected]>

feat: support singleton socket.

317d9c2

Signed-off-by: IRONICBo <[email protected]>

fix: fix wrong node entry.

af479e5

Signed-off-by: IRONICBo <[email protected]>

fix: tidy up nodeinformer.

5f49e37

Signed-off-by: IRONICBo <[email protected]>

feat: refactor monitor loop.

a75a3fe

Signed-off-by: IRONICBo <[email protected]>

fix: fix dual stack estimation.

e973d70

Signed-off-by: IRONICBo <[email protected]>

fix: fix latency store update function.

df11657

Signed-off-by: Asklv <[email protected]>

fix: remove seqID and fix comments.

24fe9bf

Signed-off-by: Asklv <[email protected]>

fix: unexport unused function.

3a3fd5b

Signed-off-by: Asklv <[email protected]>

fix: remove unused comments.

cafff0d

Signed-off-by: Asklv <[email protected]>

feat: fix wrong usage in socket.

e1a6484

Signed-off-by: Asklv <[email protected]>

fix: remove stale ips.

5659313

Signed-off-by: Asklv <[email protected]>

fix: fix nits.

8b02463

Signed-off-by: Asklv <[email protected]>

antoninbas force-pushed the 5514-ping-mesh-monitoring-tool branch from 03dc802 to 8b02463 Compare May 30, 2024 21:39

antoninbas merged commit c3103a9 into antrea-io:main May 31, 2024
51 of 55 checks passed

antoninbas added the action/release-note Indicates a PR that should be included in release notes. label May 31, 2024

luolanzone added this to the Antrea v2.1 release milestone Jun 3, 2024

IRONICBo mentioned this pull request Jun 3, 2024

Export node latency query api define. #6392

Merged

antoninbas pushed a commit that referenced this pull request Jun 18, 2024

Define API for Agents to report Node latency stats (#6392)

25899c3

Follow up to #6120 See #5514 Signed-off-by: Asklv <[email protected]>

This was referenced Jul 25, 2024

Add e2e tests for the NodeLatencyMonitor feature #6549

Closed

Add documentation for NodeLatencyMonitor #6551

Closed

Rupam-It mentioned this pull request Aug 18, 2024

Add e2e test for the NodeLatencyMonitor feature #6612

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support simple ping mesh in agent. #6120

Support simple ping mesh in agent. #6120

IRONICBo commented Mar 19, 2024

This comment was marked as outdated.

This comment was marked as resolved.

IRONICBo commented Apr 8, 2024

IRONICBo commented Apr 15, 2024

This comment was marked as spam.

heanlan commented Apr 24, 2024

antoninbas commented Apr 24, 2024

antoninbas left a comment

IRONICBo commented May 30, 2024

antoninbas commented May 30, 2024

Support simple ping mesh in agent. #6120

Support simple ping mesh in agent. #6120

Conversation

IRONICBo commented Mar 19, 2024

This comment was marked as outdated.

This comment was marked as resolved.

IRONICBo commented Apr 8, 2024

IRONICBo commented Apr 15, 2024

This comment was marked as spam.

heanlan commented Apr 24, 2024

antoninbas commented Apr 24, 2024

antoninbas left a comment

Choose a reason for hiding this comment

IRONICBo commented May 30, 2024

antoninbas commented May 30, 2024