Automated cherry pick of #4295: Add unit test for pkg/agent/route #4419: Set NO_FLOOD to IPsec tunnel ports #4470: Fix that Service routes may get lost when starting on Windows #4654: Restore NO_FLOOD to OVS ports after reconnecting the OVS #4711: Fix route deletion for Service ClusterIP and LoadBalancerIP #4767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Quan Tian <[email protected]>
Set NO_FLOOD to IPsec tunnel ports to avoid ARP flooding. Signed-off-by: Xu Liu <[email protected]>
Fix antrea-io#4467 Signed-off-by: Hongliang Liu <[email protected]>
The NO_FLOOD configuration is lost when the OVS daemon is restarted. Currently, the only way to recover this configuration is by restarting the agent. This pull request adds logic to recover the configuration when receiving OVS reconnection events. Signed-off-by: Xu Liu <[email protected]>
luolanzone
added
the
kind/cherry-pick
Codecov Report
@@ Coverage Diff @@
## release-1.8 #4767 +/- ##
===============================================
- Coverage 65.88% 64.65% -1.24%
===============================================
Files 304 305 +1
Lines 46668 46890 +222
===============================================
- Hits 30747 30316 -431
- Misses 13521 14178 +657
+ Partials 2400 2396 -4
*This pull request uses carry forward flags. Click here to find out more.
|
When proxyAll is enabled, AntreaProxy needs to install routes in the host network namespace to redirect traffic to OVS for load balancing. For a Service with multiple ports, multiple ServicePorts are generated and processed. The previous code installed the route for a ClusterIP or a LoadBalancerIP multiple times when such a Service was created, and uninstalled the route multiple times when it was deleted, leading to a few problems. This patch adds a serviceIPRouteReferences which tracks the references of Service IPs' routes. The key is the Service IP and the value is the the set of ServiceInfo strings. With the references, we install a route exactly once as long as it's used by any ServicePorts and uninstall it exactly once when it's no longer used by any ServicePorts. This patch also fixes an issue that the route for ClusterIP was not removed on Windows Nodes after the Service was removed. Fixes antrea-io#4361 Signed-off-by: Quan Tian <[email protected]>
luolanzone
force-pushed
the
automated-cherry-pick-of-#4295-#4419-#4470-#4654-#4711-upstream-release-1.8
branch
from
91717ea
to
905f653
Compare
DOCKER_REGISTRY is no longer needed in agent image tag. Remove it to align with containerd image tag in CI pipeline. Update more image tags which is unavailable in public repo. Fixes antrea-io#4696 Signed-off-by: Shuyang Xin <[email protected]>
|
#4674 is missing, leading to same test failure |
luolanzone
force-pushed
the
automated-cherry-pick-of-#4295-#4419-#4470-#4654-#4711-upstream-release-1.8
branch
from
53d77d1
to
fe59ad0
Compare
|
Golangci-lint check failed |
There could be some cases that OVS ports are left invalid. Setting NO_FLOOD for these ports will fail for sure and restarting agents would just meet the same error. Later we should enhance the port cleanup logic, either when they are firstly identified, or when their owners do the initialization. For now, as there could be invalid ports in interface cache, we should ensure a port is valid before setting NO_FLOOD. Signed-off-by: Quan Tian <[email protected]>
luolanzone
force-pushed
the
automated-cherry-pick-of-#4295-#4419-#4470-#4654-#4711-upstream-release-1.8
branch
from
fe59ad0
to
204f0da
Compare
|
/test-all |
|
/skip-e2e |
tnqn
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #4295 #4419 #4470 #4654 #4711 #4697 #4674 on release-1.8.
#4295: Add unit test for pkg/agent/route
#4419: Set NO_FLOOD to IPsec tunnel ports
#4470: Fix that Service routes may get lost when starting on Windows
#4654: Restore NO_FLOOD to OVS ports after reconnecting the OVS
#4711: Fix route deletion for Service ClusterIP and LoadBalancerIP
#4697: Fix windows image building error in jenkins pipeline
#4674:Ensure OVS port is valid before setting NO_FLOOD
For details on the cherry pick process, see the cherry pick requests page.