Import auth to support different platforms #4494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Antctl failed to talk with GCP cluster and it shows: `Error: no Auth Provider found for name "gcp"`. According to the example of client-go, we need to import auth package to support different public platform's authentication. Signed-off-by: Lan Luo <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #4494 +/- ##
==========================================
- Coverage 67.87% 66.82% -1.05%
==========================================
Files 402 404 +2
Lines 57284 60366 +3082
==========================================
+ Hits 38879 40339 +1460
- Misses 15707 17329 +1622
Partials 2698 2698
|
|
@jianjuns @tnqn @antoninbas could you take a look at this tiny PR? thanks. |
antoninbas
approved these changes
Jan 17, 2023
|
/test-all |
|
@luolanzone do you want to backport this? |
|
@antoninbas I think it's better to backport this, any suggestion? or which version we should backport to? |
It's up to you. Backporting it to v1.10 may be a good idea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Antctl failed to talk with GCP cluster and it shows:
Error: no Auth Provider found for name "gcp". According to the example of client-go, we need to import auth package to support different public platform's authentication.Here is the sample code:
https://github.com/kubernetes/client-go/blob/master/examples/out-of-cluster-client-configuration/main.go#L33-L40
Signed-off-by: Lan Luo [email protected]