Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #4388: Update openflow rules when Gateway updates #4411

Conversation

luolanzone
Copy link
Contributor

Cherry pick of #4388 on release-1.9.

#4388: Update openflow rules when Gateway updates

For details on the cherry pick process, see the cherry pick requests page.

There is a bug when GatewayIP or InternalIP of active Gateway is
changed, the corresponding openflow rules won't be updated until
any other event triggers the flow sync process.

Fix the bug by comparing installed active Gateway's InternalIP and
GatewayIP with current active Gateway. And add more unit tests to
cover Gateway update event.

Signed-off-by: Lan Luo <[email protected]>
@luolanzone luolanzone added the kind/cherry-pick Categorizes issue or PR as related to the cherry-pick of a bug fix from the main branch to a release label Nov 24, 2022
@codecov
Copy link

codecov bot commented Nov 24, 2022

Codecov Report

Merging #4411 (c9a2e91) into release-1.9 (4e30ce2) will decrease coverage by 0.93%.
The diff coverage is 72.50%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-1.9    #4411      +/-   ##
===============================================
- Coverage        63.68%   62.75%   -0.94%     
===============================================
  Files              393      404      +11     
  Lines            55538    55608      +70     
===============================================
- Hits             35372    34896     -476     
- Misses           17591    18045     +454     
- Partials          2575     2667      +92     
Flag Coverage Δ
e2e-tests 62.15% <ø> (?)
integration-tests 34.59% <ø> (+0.06%) ⬆️
kind-e2e-tests 48.80% <0.00%> (-0.12%) ⬇️
unit-tests 46.26% <72.50%> (-1.91%) ⬇️
Impacted Files Coverage Δ
pkg/agent/multicluster/mc_route_controller.go 55.08% <72.50%> (+2.63%) ⬆️
pkg/cni/client.go 0.00% <0.00%> (-77.78%) ⬇️
...kg/agent/flowexporter/connections/conntrack_ovs.go 0.00% <0.00%> (-70.91%) ⬇️
...md/multicluster-controller/clusterclaim_webhook.go 17.64% <0.00%> (-56.87%) ⬇️
.../cmd/multicluster-controller/clusterset_webhook.go 18.75% <0.00%> (-50.00%) ⬇️
pkg/agent/multicast/mcast_route_linux.go 0.00% <0.00%> (-47.50%) ⬇️
pkg/agent/util/ndp/ndp_linux.go 0.00% <0.00%> (-46.94%) ⬇️
pkg/agent/util/iptables/lock.go 33.33% <0.00%> (-46.67%) ⬇️
...ter/cmd/multicluster-controller/gateway_webhook.go 38.09% <0.00%> (-42.86%) ⬇️
pkg/agent/flowexporter/connections/conntrack.go 57.57% <0.00%> (-36.37%) ⬇️
... and 77 more

@tnqn
Copy link
Member

tnqn commented Nov 29, 2022

/test-multicluster-e2e
/skip-all

@jianjuns jianjuns merged commit 9946974 into antrea-io:release-1.9 Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cherry-pick Categorizes issue or PR as related to the cherry-pick of a bug fix from the main branch to a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants