Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OpenAPI descriptions for AntreaAgentInfo and AntreaControllerInfo #4390

Merged
merged 1 commit into from
Nov 21, 2022

Conversation

tnqn
Copy link
Member

@tnqn tnqn commented Nov 14, 2022

The property descriptions were incorrectly generated because the per-field comments were not placed before the fields.

Signed-off-by: Quan Tian [email protected]

The property descriptions were incorrectly generated because the
per-field comments were not placed before the fields.

Signed-off-by: Quan Tian <[email protected]>
@codecov
Copy link

codecov bot commented Nov 14, 2022

Codecov Report

Merging #4390 (93aba86) into main (b834567) will increase coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4390      +/-   ##
==========================================
+ Coverage   64.54%   64.68%   +0.14%     
==========================================
  Files         397      397              
  Lines       56233    56233              
==========================================
+ Hits        36293    36374      +81     
+ Misses      17281    17213      -68     
+ Partials     2659     2646      -13     
Flag Coverage Δ
integration-tests 34.59% <ø> (+0.03%) ⬆️
kind-e2e-tests 48.52% <ø> (+0.36%) ⬆️
unit-tests 48.63% <ø> (-0.03%) ⬇️
Impacted Files Coverage Δ
pkg/agent/cniserver/ipam/ipam_service.go 76.40% <0.00%> (-12.36%) ⬇️
pkg/util/ip/ip.go 86.99% <0.00%> (-3.26%) ⬇️
pkg/controller/ipam/antrea_ipam_controller.go 75.25% <0.00%> (-3.02%) ⬇️
...ntrollers/multicluster/serviceexport_controller.go 76.33% <0.00%> (-2.80%) ⬇️
pkg/agent/util/ipset/ipset.go 70.73% <0.00%> (-2.44%) ⬇️
pkg/agent/openflow/multicluster.go 44.85% <0.00%> (-1.87%) ⬇️
pkg/ipam/ipallocator/allocator.go 88.14% <0.00%> (-1.55%) ⬇️
pkg/ipam/poolallocator/allocator.go 73.57% <0.00%> (-1.43%) ⬇️
pkg/agent/cniserver/ipam/antrea_ipam_controller.go 79.45% <0.00%> (-1.37%) ⬇️
...gent/controller/noderoute/node_route_controller.go 57.99% <0.00%> (-1.31%) ⬇️
... and 27 more

Copy link
Contributor

@mengdie-song mengdie-song left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the change.

@tnqn
Copy link
Member Author

tnqn commented Nov 21, 2022

/skip-all

@tnqn tnqn merged commit bd9d56d into antrea-io:main Nov 21, 2022
@tnqn tnqn deleted the fix-openapi-doc branch November 21, 2022 15:33
GraysonWu pushed a commit to GraysonWu/antrea that referenced this pull request Jan 27, 2023
…antrea-io#4390)

The property descriptions were incorrectly generated because the
per-field comments were not placed before the fields.

Signed-off-by: Quan Tian <[email protected]>
heanlan pushed a commit to heanlan/antrea that referenced this pull request Mar 29, 2023
…antrea-io#4390)

The property descriptions were incorrectly generated because the
per-field comments were not placed before the fields.

Signed-off-by: Quan Tian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants