Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Windows AddNodePort parameter error #4103

Merged
merged 1 commit into from
Aug 17, 2022
Merged

Fix Windows AddNodePort parameter error #4103

merged 1 commit into from
Aug 17, 2022

Conversation

XinShuYang
Copy link
Contributor

@XinShuYang XinShuYang commented Aug 11, 2022 •
edited
Loading

VirtualServiceIPv4 is the wrong parameter for AddNodePort.
It should be replaced by VirtualNodePortDNATIPv4 to match the
correct IP destination.

Signed-off-by: Shuyang Xin [email protected]

@XinShuYang
Copy link
Contributor Author

/test-windows-proxyall-e2e

@codecov
Copy link

codecov bot commented Aug 11, 2022 •
edited
Loading

Codecov Report

Merging #4103 (c489297) into main (173ef52) will increase coverage by 1.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4103      +/-   ##
==========================================
+ Coverage   64.42%   65.45%   +1.02%     
==========================================
  Files         299      304       +5     
  Lines       45448    46604    +1156     
==========================================
+ Hits        29281    30503    +1222     
+ Misses      13799    13682     -117     
- Partials     2368     2419      +51
Flag Coverage Δ
integration-tests 34.96% <ø> (-0.51%) ⬇️
kind-e2e-tests 48.63% <ø> (+4.83%) ⬆️
unit-tests 44.37% <ø> (+0.10%) ⬆️
Impacted Files Coverage Δ
pkg/agent/config/node_config.go 96.00% <ø> (-4.00%) ⬇️
pkg/signals/signals.go 87.50% <0.00%> (-12.50%) ⬇️
pkg/agent/flowexporter/exporter/exporter.go 67.82% <0.00%> (-10.15%) ⬇️
pkg/agent/openflow/framework.go 89.92% <0.00%> (-10.08%) ⬇️
pkg/agent/util/net_linux.go 32.25% <0.00%> (-9.51%) ⬇️
pkg/ovs/ovsctl/appctl.go 34.17% <0.00%> (-7.69%) ⬇️
pkg/agent/querier/querier.go 80.86% <0.00%> (-3.48%) ⬇️
pkg/agent/openflow/cookie/allocator.go 73.33% <0.00%> (-3.42%) ⬇️
pkg/features/antrea_features.go 8.00% <0.00%> (-3.12%) ⬇️
... and 76 more

@wenyingd wenyingd mentioned this pull request Aug 11, 2022
Merged
@XinShuYang
Copy link
Contributor Author

/test-windows-proxyall-e2e

4 similar comments
@XinShuYang
Copy link
Contributor Author

/test-windows-proxyall-e2e

@XinShuYang
Copy link
Contributor Author

/test-windows-proxyall-e2e

@XinShuYang
Copy link
Contributor Author

/test-windows-proxyall-e2e

@XinShuYang
Copy link
Contributor Author

/test-windows-proxyall-e2e

@XinShuYang
Copy link
Contributor Author

/test-windows-proxyall-e2e

@XinShuYang
Copy link
Contributor Author

/test-windows-proxyall-e2e
/test-windows-proxyall-e2e

@XinShuYang
Copy link
Contributor Author

/test-windows-proxyall-e2e
/test-windows-proxyall-e2e

@XinShuYang
Copy link
Contributor Author

/test-windows-proxyall-e2e
/test-windows-proxyall-e2e

@XinShuYang
Copy link
Contributor Author

/test-windows-proxyall-e2e

1 similar comment
@XinShuYang
Copy link
Contributor Author

/test-windows-proxyall-e2e

@XinShuYang
Copy link
Contributor Author

/test-windows-proxyall-e2e

@XinShuYang XinShuYang marked this pull request as ready for review August 17, 2022 02:32
wenyingd
wenyingd previously approved these changes Aug 17, 2022
View reviewed changes
@XinShuYang XinShuYang force-pushed the nodeportfix branch 3 times, most recently from 9956d82 to bebebc5 Compare August 17, 2022 02:43
wenyingd
wenyingd previously approved these changes Aug 17, 2022
View reviewed changes
tnqn
tnqn reviewed Aug 17, 2022
View reviewed changes
Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hongliangl could you also take a look?

pkg/agent/route/route_windows.go Show resolved Hide resolved
@XinShuYang
Copy link
Contributor Author

/test-windows-all

@XinShuYang
Fix Windows AddNodePort parameter error
c489297 
VirtualServiceIPv4 is the wrong parameter for AddNodePort.
It should be replaced by VirtualNodePortDNATIPv4 to match the
correct IP destination.

Signed-off-by: Shuyang Xin <[email protected]>
@XinShuYang
Copy link
Contributor Author

/test-windows-all

@XinShuYang XinShuYang requested a review from tnqn August 17, 2022 05:18
tnqn
tnqn approved these changes Aug 17, 2022
View reviewed changes
Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tnqn
Copy link
Member

tnqn commented Aug 17, 2022

/skip-all

@tnqn tnqn merged commit 5e2bafe into antrea-io:main Aug 17, 2022
@tnqn tnqn added action/backport Indicates a PR that requires backports. action/release-note Indicates a PR that should be included in release notes. labels Dec 7, 2022
@XinShuYang XinShuYang mentioned this pull request Dec 7, 2022
Merged
heanlan pushed a commit to heanlan/antrea that referenced this pull request Mar 29, 2023
@XinShuYang @heanlan
Fix Windows AddNodePort parameter error (antrea-io#4103)
1f5c46e 
VirtualServiceIPv4 is the wrong parameter for AddNodePort.
It should be replaced by VirtualNodePortDNATIPv4 to match the
correct IP destination.

Signed-off-by: Shuyang Xin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnqn tnqn tnqn approved these changes

@wenyingd wenyingd wenyingd left review comments

@hongliangl hongliangl Awaiting requested review from hongliangl

Assignees
No one assigned
Labels
action/backport Indicates a PR that requires backports. action/release-note Indicates a PR that should be included in release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@XinShuYang @tnqn @wenyingd