-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use hostNetwork for Multi-cluster controller #3965
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `hostNetwork` mode is required to run Multi-cluster controller on a public cloud like EKS clusters. Signed-off-by: Lan Luo <[email protected]>
luolanzone
force-pushed
the
mc-hostnetwork
branch
from
July 5, 2022 01:16
c31d97d
to
2b676ea
Compare
/test-multicluster-e2e |
Codecov Report
@@ Coverage Diff @@
## main #3965 +/- ##
==========================================
+ Coverage 64.39% 64.57% +0.17%
==========================================
Files 294 294
Lines 43627 43627
==========================================
+ Hits 28095 28173 +78
+ Misses 13258 13160 -98
- Partials 2274 2294 +20
|
Why it is required for EKS? |
Ok, guess you mean the webhook part. |
jianjuns
approved these changes
Jul 6, 2022
Yes, we have webhooks on Antrea MC controller, and it will fail if it's not running with hostNetwork mode in EKS clusters. |
/skip-all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
hostNetwork
mode is required to run Multi-cluster controller on a publiccloud like EKS clusters.
Signed-off-by: Lan Luo [email protected]