Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use hostNetwork for Multi-cluster controller #3965

Merged
merged 1 commit into from
Jul 6, 2022

Conversation

luolanzone
Copy link
Contributor

The hostNetwork mode is required to run Multi-cluster controller on a public
cloud like EKS clusters.

Signed-off-by: Lan Luo [email protected]

The `hostNetwork` mode is required to run Multi-cluster controller on a public
cloud like EKS clusters.

Signed-off-by: Lan Luo <[email protected]>
@luolanzone
Copy link
Contributor Author

/test-multicluster-e2e

@luolanzone luolanzone added the area/multi-cluster Issues or PRs related to multi cluster. label Jul 5, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2022

Codecov Report

Merging #3965 (2b676ea) into main (79b6480) will increase coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3965      +/-   ##
==========================================
+ Coverage   64.39%   64.57%   +0.17%     
==========================================
  Files         294      294              
  Lines       43627    43627              
==========================================
+ Hits        28095    28173      +78     
+ Misses      13258    13160      -98     
- Partials     2274     2294      +20     
Flag Coverage Δ
kind-e2e-tests 51.18% <ø> (+0.39%) ⬆️
unit-tests 44.35% <ø> (-0.04%) ⬇️
Impacted Files Coverage Δ
.../agent/flowexporter/priorityqueue/priorityqueue.go 60.75% <0.00%> (-31.65%) ⬇️
pkg/agent/nodeportlocal/k8s/annotations.go 84.44% <0.00%> (-15.56%) ⬇️
pkg/agent/flowexporter/utils.go 61.70% <0.00%> (-12.77%) ⬇️
pkg/controller/externalippool/controller.go 84.82% <0.00%> (-6.25%) ⬇️
pkg/controller/networkpolicy/store/addressgroup.go 87.20% <0.00%> (-3.49%) ⬇️
pkg/controller/networkpolicy/status_controller.go 68.54% <0.00%> (-3.23%) ⬇️
...r/ipseccertificate/ipsec_certificate_controller.go 61.56% <0.00%> (-1.96%) ⬇️
pkg/ovs/openflow/ofctrl_packetout.go 79.71% <0.00%> (-0.87%) ⬇️
pkg/agent/controller/trafficcontrol/controller.go 82.36% <0.00%> (-0.86%) ⬇️
pkg/ovs/openflow/ofctrl_bridge.go 56.86% <0.00%> (-0.20%) ⬇️
... and 14 more

@luolanzone luolanzone requested review from jianjuns and tnqn July 5, 2022 03:27
@jianjuns
Copy link
Contributor

jianjuns commented Jul 5, 2022

Why it is required for EKS?

@luolanzone
Copy link
Contributor Author

@jianjuns according to our doc here, there is a limitation for encap mode: as a general limitation when using custom CNIs with EKS, Antrea cannot be installed to the EKS control plane Nodes. As a result, EKS control plane cannot initiate a connection to a Pod in Antrea overlay network

@jianjuns
Copy link
Contributor

jianjuns commented Jul 6, 2022

Ok, guess you mean the webhook part.

@luolanzone
Copy link
Contributor Author

Yes, we have webhooks on Antrea MC controller, and it will fail if it's not running with hostNetwork mode in EKS clusters.

@jianjuns
Copy link
Contributor

jianjuns commented Jul 6, 2022

/skip-all
The change impacts only MC controller.

@jianjuns jianjuns merged commit 6070794 into antrea-io:main Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/multi-cluster Issues or PRs related to multi cluster.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants