Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #2305: Fix wrong types and missing field selectors in legacy APIs #2314

Conversation

tnqn
Copy link
Member

@tnqn tnqn commented Jun 25, 2021

Cherry pick of #2305 on release-1.0.

#2305: Fix wrong types and missing field selectors in legacy APIs

For details on the cherry pick process, see the cherry pick requests page.

@tnqn tnqn added the kind/cherry-pick Categorizes issue or PR as related to the cherry-pick of a bug fix from the main branch to a release label Jun 25, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2021

Codecov Report

Merging #2314 (d1921d5) into release-1.0 (f79e214) will decrease coverage by 4.89%.
The diff coverage is 51.72%.

❗ Current head d1921d5 differs from pull request most recent head d192150. Consider uploading reports for the commit d192150 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           release-1.0    #2314      +/-   ##
===============================================
- Coverage        61.19%   56.29%   -4.90%     
===============================================
  Files              270      266       -4     
  Lines            20384    19601     -783     
===============================================
- Hits             12474    11035    -1439     
- Misses            6620     7196     +576     
- Partials          1290     1370      +80     
Flag Coverage Δ
e2e-tests 56.29% <51.72%> (?)
kind-e2e-tests ?
unit-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/legacyapis/controlplane/v1beta1/conversion.go 30.00% <30.00%> (ø)
pkg/legacyapis/networking/v1beta1/conversion.go 30.00% <30.00%> (ø)
pkg/legacyapis/controlplane/v1beta1/register.go 92.85% <100.00%> (ø)
pkg/controller/networkpolicy/endpoint_querier.go 2.85% <0.00%> (-88.58%) ⬇️
pkg/controller/egress/controller.go 0.00% <0.00%> (-83.88%) ⬇️
pkg/apis/controlplane/v1beta1/conversion.go 1.20% <0.00%> (-83.14%) ⬇️
pkg/agent/util/iptables/lock.go 0.00% <0.00%> (-81.82%) ⬇️
...kg/agent/flowexporter/connections/conntrack_ovs.go 0.00% <0.00%> (-77.02%) ⬇️
pkg/cni/client.go 0.00% <0.00%> (-75.52%) ⬇️
pkg/apiserver/handlers/endpoint/handler.go 0.00% <0.00%> (-70.59%) ⬇️
... and 110 more

@tnqn
Copy link
Member Author

tnqn commented Jun 25, 2021

/test-all

1. v1beta1.controlplane.antrea.tanzu.vmware.com used v1beta2 types by
mistake.

2. Field selectors for v1beta1.controlplane.antrea.tanzu.vmware.com
was not registered, which broke "nodeName" fieldSelector.

Signed-off-by: Quan Tian <[email protected]>
@tnqn tnqn force-pushed the automated-cherry-pick-of-#2305-upstream-release-1.0 branch from 2569723 to d192150 Compare June 28, 2021 03:36
@tnqn
Copy link
Member Author

tnqn commented Jun 28, 2021

/test-e2e

@tnqn
Copy link
Member Author

tnqn commented Jun 28, 2021

/test-networkpolicy
/test-conformance

@tnqn tnqn merged commit e8bf52d into antrea-io:release-1.0 Jun 28, 2021
@tnqn tnqn deleted the automated-cherry-pick-of-#2305-upstream-release-1.0 branch June 28, 2021 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cherry-pick Categorizes issue or PR as related to the cherry-pick of a bug fix from the main branch to a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants