-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wrong types and missing field selectors in legacy APIs #2305
Conversation
1. v1beta1.controlplane.antrea.tanzu.vmware.com used v1beta2 types by mistake. 2. Field selectors for v1beta1.controlplane.antrea.tanzu.vmware.com was not registered, which broke "nodeName" fieldSelector. Signed-off-by: Quan Tian <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #2305 +/- ##
==========================================
+ Coverage 62.05% 62.06% +0.01%
==========================================
Files 277 278 +1
Lines 21588 21598 +10
==========================================
+ Hits 13396 13405 +9
- Misses 6792 6795 +3
+ Partials 1400 1398 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/test-all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I also think it should be backported
/test-e2e |
/skip-e2e Skip it as the e2e test succeeded but failed to collect coverage data:
|
v1beta1.controlplane.antrea.tanzu.vmware.com used v1beta2 types by
mistake.
Field selectors for v1beta1.controlplane.antrea.tanzu.vmware.com
was not registered, which broke "nodeName" fieldSelector.
Signed-off-by: Quan Tian [email protected]
Fixes #2304
It may need to be backported to 1.0 and 1.1.