Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong types and missing field selectors in legacy APIs #2305

Merged
merged 1 commit into from
Jun 25, 2021

Conversation

tnqn
Copy link
Member

@tnqn tnqn commented Jun 24, 2021

  1. v1beta1.controlplane.antrea.tanzu.vmware.com used v1beta2 types by
    mistake.

  2. Field selectors for v1beta1.controlplane.antrea.tanzu.vmware.com
    was not registered, which broke "nodeName" fieldSelector.

Signed-off-by: Quan Tian [email protected]

Fixes #2304

It may need to be backported to 1.0 and 1.1.

1. v1beta1.controlplane.antrea.tanzu.vmware.com used v1beta2 types by
mistake.

2. Field selectors for v1beta1.controlplane.antrea.tanzu.vmware.com
was not registered, which broke "nodeName" fieldSelector.

Signed-off-by: Quan Tian <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2021

Codecov Report

Merging #2305 (e3428db) into main (ef14ad1) will increase coverage by 0.01%.
The diff coverage is 63.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2305      +/-   ##
==========================================
+ Coverage   62.05%   62.06%   +0.01%     
==========================================
  Files         277      278       +1     
  Lines       21588    21598      +10     
==========================================
+ Hits        13396    13405       +9     
- Misses       6792     6795       +3     
+ Partials     1400     1398       -2     
Flag Coverage Δ
e2e-tests ∅ <ø> (?)
kind-e2e-tests 52.38% <63.15%> (+0.03%) ⬆️
unit-tests 41.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/legacyapis/controlplane/v1beta1/conversion.go 30.00% <30.00%> (ø)
pkg/legacyapis/controlplane/v1beta1/register.go 92.85% <100.00%> (ø)
pkg/controller/networkpolicy/status_controller.go 86.45% <0.00%> (-0.65%) ⬇️
pkg/agent/route/route_linux.go 44.14% <0.00%> (-0.54%) ⬇️
pkg/agent/agent.go 49.88% <0.00%> (-0.46%) ⬇️
pkg/agent/openflow/pipeline.go 71.69% <0.00%> (-0.17%) ⬇️
pkg/agent/util/iptables/iptables.go 39.68% <0.00%> (+0.79%) ⬆️
pkg/controller/networkpolicy/validate.go 71.58% <0.00%> (+1.94%) ⬆️
pkg/agent/stats/collector.go 98.46% <0.00%> (+3.84%) ⬆️

@tnqn
Copy link
Member Author

tnqn commented Jun 24, 2021

/test-all

Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I also think it should be backported

@tnqn
Copy link
Member Author

tnqn commented Jun 25, 2021

/test-e2e

@tnqn
Copy link
Member Author

tnqn commented Jun 25, 2021

/skip-e2e

Skip it as the e2e test succeeded but failed to collect coverage data:

PASS
2021-06-24 15:15:24.747655 I | Error when gracefully exit antrea controller: error when getting antrea-controller Pod: failed to list Antrea Controller: Get "https://192.168.9.150:6443/api/v1/namespaces/kube-system/pods?labelSelector=app%3Dantrea%2Ccomponent%3Dantrea-controller": dial tcp 192.168.9.150:6443: i/o timeout
FAIL	antrea.io/antrea/test/e2e	5054.055s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v1beta1.controlplane.antrea.tanzu.vmware.com used v1beta2 types and field selectors were missing
5 participants