[Windows] Fix timeout value for EnableHostInterface #2081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The second parameter to wait.PollImmediate (the timeout) is a time.Duration value. When using 5 as the parameter value, it is interpreted as 5ns, and not 5s. This means that EnableHostInterface basically never does any retry.
|
See https://play.golang.org/p/7bw-WetmnjW for a live example |
|
Found this issue by looking at logs that @mmottaghi shared with me |
Codecov Report
@@ Coverage Diff @@
## main #2081 +/- ##
===========================================
+ Coverage 41.35% 54.94% +13.59%
===========================================
Files 131 270 +139
Lines 16434 20366 +3932
===========================================
+ Hits 6797 11191 +4394
+ Misses 9059 7977 -1082
- Partials 578 1198 +620
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
/test-all |
antoninbas
added a commit
to antoninbas/antrea
that referenced
this pull request
Apr 29, 2021
The second parameter to wait.PollImmediate (the timeout) is a time.Duration value. When using 5 as the parameter value, it is interpreted as 5ns, and not 5s. This means that EnableHostInterface basically never does any retry.
antoninbas
added a commit
that referenced
this pull request
Apr 30, 2021
The second parameter to wait.PollImmediate (the timeout) is a time.Duration value. When using 5 as the parameter value, it is interpreted as 5ns, and not 5s. This means that EnableHostInterface basically never does any retry.
antoninbas
added a commit
to antoninbas/antrea
that referenced
this pull request
Apr 30, 2021
The second parameter to wait.PollImmediate (the timeout) is a time.Duration value. When using 5 as the parameter value, it is interpreted as 5ns, and not 5s. This means that EnableHostInterface basically never does any retry.
antoninbas
added a commit
to antoninbas/antrea
that referenced
this pull request
Apr 30, 2021
The second parameter to wait.PollImmediate (the timeout) is a time.Duration value. When using 5 as the parameter value, it is interpreted as 5ns, and not 5s. This means that EnableHostInterface basically never does any retry.
antoninbas
added a commit
that referenced
this pull request
Apr 30, 2021
The second parameter to wait.PollImmediate (the timeout) is a time.Duration value. When using 5 as the parameter value, it is interpreted as 5ns, and not 5s. This means that EnableHostInterface basically never does any retry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The second parameter to wait.PollImmediate (the timeout) is a
time.Duration value. When using 5 as the parameter value, it is
interpreted as 5ns, and not 5s. This means that EnableHostInterface
basically never does any retry.