Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IPv6 flow for traceflowConnectionTrackFlows #2054

Merged
merged 1 commit into from
Apr 9, 2021

Conversation

jianjuns
Copy link
Contributor

@jianjuns jianjuns commented Apr 9, 2021

No description provided.

@antoninbas
Copy link
Contributor

Is this a bug fix? Does it explain some of the IPv6 Traceflow test failures?

@jianjuns
Copy link
Contributor Author

jianjuns commented Apr 9, 2021

@gran-vmv @antoninbas : I think we should add a conntrackStateTable flow for IPv6 too. Could you check?

@jianjuns
Copy link
Contributor Author

jianjuns commented Apr 9, 2021

Is this a bug fix? Does it explain some of the IPv6 Traceflow test failures?

I feel it could not explain the test failure I know (the UDP IPv6 failure in e2e tests).

@jianjuns
Copy link
Contributor Author

jianjuns commented Apr 9, 2021

/test-ipv6-e2e

antoninbas
antoninbas previously approved these changes Apr 9, 2021
Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I guess this would only be an issue for a TCPv6 Traceflow packet without the SYN flag set, which is probably not something we test

@codecov-io
Copy link

codecov-io commented Apr 9, 2021

Codecov Report

Merging #2054 (ffc4031) into main (6f25769) will decrease coverage by 5.91%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2054      +/-   ##
==========================================
- Coverage   61.06%   55.15%   -5.92%     
==========================================
  Files         268      269       +1     
  Lines       20236    20374     +138     
==========================================
- Hits        12357    11237    -1120     
- Misses       6601     7934    +1333     
+ Partials     1278     1203      -75     
Flag Coverage Δ
kind-e2e-tests 40.79% <85.71%> (-10.92%) ⬇️
unit-tests 41.03% <0.00%> (-0.52%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/agent/openflow/pipeline.go 66.40% <85.71%> (-1.39%) ⬇️
pkg/apis/controlplane/helper.go 25.00% <0.00%> (-75.00%) ⬇️
pkg/apis/controlplane/v1beta2/helper.go 25.00% <0.00%> (-75.00%) ⬇️
pkg/controller/networkpolicy/mutate.go 0.00% <0.00%> (-71.77%) ⬇️
pkg/controller/networkpolicy/store/group.go 5.00% <0.00%> (-70.00%) ⬇️
pkg/controller/networkpolicy/validate.go 0.00% <0.00%> (-69.47%) ⬇️
pkg/k8s/name.go 33.33% <0.00%> (-66.67%) ⬇️
...formers/externalversions/security/v1alpha1/tier.go 0.00% <0.00%> (-64.29%) ⬇️
...ers/externalversions/core/v1alpha2/clustergroup.go 0.00% <0.00%> (-64.29%) ⬇️
...s/externalversions/core/v1alpha2/externalentity.go 0.00% <0.00%> (-64.29%) ⬇️
... and 67 more

@gran-vmv
Copy link
Contributor

gran-vmv commented Apr 9, 2021

@jianjuns Could you also fix this? #2029 (review)

@antoninbas antoninbas added this to the Antrea v1.0 release milestone Apr 9, 2021
@gran-vmv
Copy link
Contributor

gran-vmv commented Apr 9, 2021

@jianjuns Could you also fix this? #2029 (review)

PR for this issue: #2059

@jianjuns
Copy link
Contributor Author

jianjuns commented Apr 9, 2021

/test-all

@antoninbas antoninbas merged commit b9334e3 into antrea-io:main Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants