Change flow-aggregator base images to reduce image size #2004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Found |
antoninbas
requested changes
Mar 27, 2021
There was a problem hiding this comment.
We cannot use alpine as a base image for VMware originated open-source software. We should fix the netpol image as well but at least it is only used for testing.
I suggested using distroless in the issue. Please use scratch since we are only including a static Go binary.
hanlins
force-pushed
the
fix/1986/flow-aggregator-base-img
branch
from
c9023a8
to
732262f
Compare
|
kk, fixed. |
Codecov Report
@@ Coverage Diff @@
## main #2004 +/- ##
==========================================
+ Coverage 65.14% 65.34% +0.20%
==========================================
Files 197 197
Lines 17407 17407
==========================================
+ Hits 11340 11375 +35
+ Misses 4880 4858 -22
+ Partials 1187 1174 -13
Flags with carried forward coverage won't be shown. Click here to find out more.
|
antoninbas
previously approved these changes
Mar 27, 2021
hanlins
force-pushed
the
fix/1986/flow-aggregator-base-img
branch
from
732262f
to
4333de5
Compare
srikartati
reviewed
Mar 29, 2021
| @@ -7,7 +7,7 @@ COPY . /antrea | |||
|
|
|||
| RUN make flow-aggregator | |||
|
|
|||
| FROM antrea/base-ubuntu:${OVS_VERSION} | |||
| FROM scratch | |||
There was a problem hiding this comment.
/cc @dreamtalen @zyiou who contributes to Flow Aggregator feature.
antoninbas
reviewed
Mar 29, 2021
hack/netpol/Dockerfile
Outdated
| @@ -4,6 +4,6 @@ ADD ./ /netpol | |||
| WORKDIR /netpol | |||
| RUN go build -o main pkg/main/main.go | |||
|
|
|||
| FROM alpine | |||
| FROM scratch | |||
There was a problem hiding this comment.
I suggested doing this in a separate PR
There was a problem hiding this comment.
I see, will revert that change, thx!
There was a problem hiding this comment.
Done, will put the change for netpol image in another PR.
hanlins
changed the title
hanlins
force-pushed
the
fix/1986/flow-aggregator-base-img
branch
from
4333de5
to
74b8b6c
Compare
hanlins
changed the title
|
/test-e2e |
antoninbas
approved these changes
Mar 29, 2021
|
|
dreamtalen
added a commit
to dreamtalen/antrea
that referenced
this pull request
Mar 31, 2021
Fix the error of Flow Aggregator image after PR antrea-io#2004 changed the base image to scratch. Change the image name target "flow-aggregator-ubuntu" to "flow-aggregtor-image" in Makefile since ubuntu is not relevant. Change the base image of Flow Aggregator code coverage image to ubuntu:20.04.
dreamtalen
added a commit
to dreamtalen/antrea
that referenced
this pull request
Mar 31, 2021
Fix the error of Flow Aggregator image after PR antrea-io#2004 changed the base image to scratch. Change the image name target "flow-aggregator-ubuntu" to "flow-aggregtor-image" in Makefile since ubuntu is not relevant. Change the base image of Flow Aggregator code coverage image to ubuntu:20.04.
dreamtalen
added a commit
to dreamtalen/antrea
that referenced
this pull request
Mar 31, 2021
Fix the error of Flow Aggregator image after PR antrea-io#2004 changed the base image to scratch. Change the image name target "flow-aggregator-ubuntu" to "flow-aggregtor-image" in Makefile since ubuntu is not relevant. Change the base image of Flow Aggregator code coverage image to ubuntu:20.04.
dreamtalen
added a commit
to dreamtalen/antrea
that referenced
this pull request
Apr 1, 2021
Fix the error of Flow Aggregator image after PR antrea-io#2004 changed the base image to scratch. Change the image name target "flow-aggregator-ubuntu" to "flow-aggregtor-image" in Makefile since ubuntu is not relevant. Change the base image of Flow Aggregator code coverage image to ubuntu:20.04.
dreamtalen
added a commit
to dreamtalen/antrea
that referenced
this pull request
Apr 1, 2021
Fix the error of Flow Aggregator image after PR antrea-io#2004 changed the base image to scratch. Change the image name target "flow-aggregator-ubuntu" to "flow-aggregtor-image" in Makefile since ubuntu is not relevant. Change the base image of Flow Aggregator code coverage image to ubuntu:20.04.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flow aggregator only needs the Golang binary and doesn't have dependencies on OVS. Changing the base image to reduce image size.
Closes #1986.