Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VM Agent e2e test failed because of the change in support bundle content #6215

Closed
wenyingd opened this issue Apr 11, 2024 · 0 comments · Fixed by #6216
Closed

VM Agent e2e test failed because of the change in support bundle content #6215

wenyingd opened this issue Apr 11, 2024 · 0 comments · Fixed by #6216
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@wenyingd
Copy link
Contributor

wenyingd commented Apr 11, 2024

Describe the bug

Hi,

VM Agent e2e test failed with the below error,

    vmagent_test.go:224: Actual files after extracting SupportBundleCollection tarball vmbmtest0-win-0_support-bundle-collection-external-node: [addressgroups agentinfo appliedtogroups flows goroutinestacks groups ipconfig logs\ovs\ovs-vswitchd.log logs\ovs\ovsdb-server.log memprofile network-adapters networkpolicies ovsports routes]
    vmagent_test.go:225: 
        	Error Trace:	/var/lib/jenkins/workspace/antrea-vm-e2e-for-pull-request/test/e2e/vmagent_test.go:225
        	            				/var/lib/jenkins/workspace/antrea-vm-e2e-for-pull-request/test/e2e/vmagent_test.go:82
        	Error:      	elements differ
        	            	
        	            	extra elements in list B:
        	            	([]interface {}) (len=1) {
        	            	 (string) (len=6) "groups"
        	            	}
        	            	
        	            	
        	            	listA:
        	            	([]string) (len=13) {
        	            	 (string) (len=13) "addressgroups",
        	            	 (string) (len=9) "agentinfo",
        	            	 (string) (len=15) "appliedtogroups",
        	            	 (string) (len=5) "flows",
        	            	 (string) (len=15) "goroutinestacks",
        	            	 (string) (len=8) "ipconfig",
        	            	 (string) (len=25) "logs\\ovs\\ovs-vswitchd.log",
        	            	 (string) (len=25) "logs\\ovs\\ovsdb-server.log",
        	            	 (string) (len=10) "memprofile",
        	            	 (string) (len=16) "network-adapters",
        	            	 (string) (len=15) "networkpolicies",
        	            	 (string) (len=8) "ovsports",
        	            	 (string) (len=6) "routes"
        	            	}
        	            	
        	            	
        	            	listB:
        	            	([]string) (len=14) {
        	            	 (string) (len=13) "addressgroups",
        	            	 (string) (len=9) "agentinfo",
        	            	 (string) (len=15) "appliedtogroups",
        	            	 (string) (len=5) "flows",
        	            	 (string) (len=15) "goroutinestacks",
        	            	 (string) (len=6) "groups",
        	            	 (string) (len=8) "ipconfig",
        	            	 (string) (len=25) "logs\\ovs\\ovs-vswitchd.log",
        	            	 (string) (len=25) "logs\\ovs\\ovsdb-server.log",
        	            	 (string) (len=10) "memprofile",
        	            	 (string) (len=16) "network-adapters",
        	            	 (string) (len=15) "networkpolicies",
        	            	 (string) (len=8) "ovsports",
        	            	 (string) (len=6) "routes"
        	            	}
        	Test:       	TestVMAgent/testExternalNodeSupportBundleCollection
...
    --- FAIL: TestVMAgent/testExternalNodeSupportBundleCollection (15.89s)

e2e link: http://10.176.27.169:8080/job/antrea-vm-e2e-for-pull-request/586

The failure is because of this change #6195 which added OVS groups in the support bundle files, but the VM agent e2e case is not updated accordingly.

To Reproduce

Expected

Actual behavior

Versions:

Additional context

@wenyingd wenyingd added the kind/bug Categorizes issue or PR as related to a bug. label Apr 11, 2024
@wenyingd wenyingd changed the title VM Agent e2e test failed VM Agent e2e test failed because of the change in support bundle content Apr 11, 2024
@antoninbas antoninbas self-assigned this Apr 11, 2024
antoninbas added a commit to antoninbas/antrea that referenced this issue Apr 11, 2024
The test was failing because of a missing expected entry for the
supportbundle (OVS groups, which was added recently).

Because this is not the first time that it happens, we relax the test so
that it no longer fails when the supportbundle actual contents are not
an exact match with the expected contents (they have to be a superset).

Fixes antrea-io#6215

Signed-off-by: Antonin Bas <[email protected]>
antoninbas added a commit to antoninbas/antrea that referenced this issue Apr 12, 2024
The test was failing because of a missing expected entry for the
supportbundle (OVS groups, which was added recently).

Because this is not the first time that it happens, we relax the test so
that it no longer fails when the supportbundle actual contents are not
an exact match with the expected contents (they have to be a superset).

Fixes antrea-io#6215

Signed-off-by: Antonin Bas <[email protected]>
antoninbas added a commit that referenced this issue Apr 12, 2024
The test was failing because of a missing expected entry for the
supportbundle (OVS groups, which was added recently).

Because this is not the first time that it happens, we relax the test so
that it no longer fails when the supportbundle actual contents are not
an exact match with the expected contents (they have to be a superset).

Fixes #6215

Signed-off-by: Antonin Bas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants