Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve "antctl mc" usage #6151

Closed
antoninbas opened this issue Mar 26, 2024 · 9 comments
Closed

Improve "antctl mc" usage #6151

antoninbas opened this issue Mar 26, 2024 · 9 comments
Labels
area/component/antctl Issues or PRs releated to the command line interface component area/multi-cluster Issues or PRs related to multi cluster. good first issue Good for newcomers

Comments

@antoninbas
Copy link
Contributor

When I used the wrong Antrea version tag by mistake, I got the following error:

antctl mc deploy leadercluster -n antrea-multicluster --antrea-version 1.15.0
Error: json: cannot unmarshal string into Go value of type unstructured.detector

The error is because the tag should b v1.15.0 instead of 1.15.0.

It would be good IMO if the v was optional (i.e., we could support both formats). And it would also be good to have a better error message if someone provides an invalid tag or a tag that doesn't exist.

cc @luolanzone

@antoninbas antoninbas added good first issue Good for newcomers area/component/antctl Issues or PRs releated to the command line interface component area/multi-cluster Issues or PRs related to multi cluster. labels Mar 26, 2024
@luolanzone
Copy link
Contributor

@hjiajing

@hjiajing
Copy link
Contributor

@hjiajing

Thanks for the reminder, I will check and fix this.

@EraKin575
Copy link

can I work on this issue?

@antoninbas
Copy link
Contributor Author

@EraKin575, @hjiajing may be working on this already. If not, you are welcome to submit a PR.

@hjiajing
Copy link
Contributor

hjiajing commented Apr 2, 2024

Hi @antoninbas , I have not worked on this yet, maybe @EraKin575 could do it.

@antoninbas
Copy link
Contributor Author

@EraKin575 feel free to submit a PR for this

@luolanzone
Copy link
Contributor

Hi @EraKin575 are you still actively working on this issue?

@roopeshsn
Copy link
Contributor

Hi @luolanzone! I am working on this issue and will try to raise a PR by today.

@antoninbas
Copy link
Contributor Author

Fixed by #6287

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/component/antctl Issues or PRs releated to the command line interface component area/multi-cluster Issues or PRs related to multi cluster. good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants