Skip to content

Commit

Permalink
Promote feature CleanupStaleUDPSvcConntrack from Alpha to Beta
Browse files Browse the repository at this point in the history
In #5112, due to the limitations of the Go netlink library, AntreaProxy
would unconditionally delete conntrack entries added by kube-proxy in
conntrack zone 0. AntreaProxy was supposed to only delete its own entries
in conntrack zones 65520 or 65521. To address this, a feature was added
to isolate the relevant code.

After the merge of #6193, the netlink library was updated, allowing
AntreaProxy to precisely delete conntrack entries in zones 65520 or 65521.
It is now safe to enable the corresponding code by default.

Signed-off-by: Hongliang Liu <[email protected]>
  • Loading branch information
hongliangl committed May 28, 2024
1 parent df1655c commit 50c73bb
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion docs/feature-gates.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ edit the Agent configuration in the
| `AntreaProxy` | Agent | `true` | GA | v0.8 | v0.11 | v1.14 | Yes | Must be enabled for Windows. |
| `EndpointSlice` | Agent | `true` | GA | v0.13.0 | v1.11 | v1.14 | Yes | |
| `TopologyAwareHints` | Agent | `true` | Beta | v1.8 | v1.12 | N/A | Yes | |
| `CleanupStaleUDPSvcConntrack` | Agent | `false` | Alpha | v1.13 | N/A | N/A | Yes | |
| `CleanupStaleUDPSvcConntrack` | Agent | `true` | Beta | v1.13 | v2.1 | N/A | Yes | |
| `LoadBalancerModeDSR` | Agent | `false` | Alpha | v1.13 | N/A | N/A | Yes | |
| `AntreaPolicy` | Agent + Controller | `true` | Beta | v0.8 | v1.0 | N/A | No | Agent side config required from v0.9.0+. |
| `Traceflow` | Agent + Controller | `true` | Beta | v0.8 | v0.11 | N/A | Yes | |
Expand Down
2 changes: 1 addition & 1 deletion pkg/apiserver/handlers/featuregates/handler_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ func Test_getGatesResponse(t *testing.T) {
{Component: "agent", Name: "AntreaIPAM", Status: "Disabled", Version: "ALPHA"},
{Component: "agent", Name: "AntreaPolicy", Status: "Disabled", Version: "BETA"},
{Component: "agent", Name: "AntreaProxy", Status: "Enabled", Version: "GA"},
{Component: "agent", Name: "CleanupStaleUDPSvcConntrack", Status: "Disabled", Version: "ALPHA"},
{Component: "agent", Name: "CleanupStaleUDPSvcConntrack", Status: "Enabled", Version: "BETA"},
{Component: "agent", Name: "Egress", Status: egressStatus, Version: "BETA"},
{Component: "agent", Name: "EgressSeparateSubnet", Status: "Disabled", Version: "ALPHA"},
{Component: "agent", Name: "EgressTrafficShaping", Status: "Disabled", Version: "ALPHA"},
Expand Down
3 changes: 2 additions & 1 deletion pkg/features/antrea_features.go
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ const (
TopologyAwareHints featuregate.Feature = "TopologyAwareHints"

// alpha: v1.13
// beta: v2.1
// Enable support for cleaning up stale UDP Service conntrack connections in AntreaProxy.
CleanupStaleUDPSvcConntrack featuregate.Feature = "CleanupStaleUDPSvcConntrack"

Expand Down Expand Up @@ -177,7 +178,7 @@ var (
Egress: {Default: true, PreRelease: featuregate.Beta},
EndpointSlice: {Default: true, PreRelease: featuregate.GA},
TopologyAwareHints: {Default: true, PreRelease: featuregate.Beta},
CleanupStaleUDPSvcConntrack: {Default: false, PreRelease: featuregate.Alpha},
CleanupStaleUDPSvcConntrack: {Default: true, PreRelease: featuregate.Beta},
Traceflow: {Default: true, PreRelease: featuregate.Beta},
AntreaIPAM: {Default: false, PreRelease: featuregate.Alpha},
FlowExporter: {Default: false, PreRelease: featuregate.Alpha},
Expand Down

0 comments on commit 50c73bb

Please sign in to comment.