Skip to content
This repository was archived by the owner on Jan 16, 2026. It is now read-only.

feat: Remove thiserror#735

Merged
refcell merged 1 commit intomainfrom
rf/feat/remove-thiserror
Oct 25, 2024
Merged

feat: Remove thiserror#735
refcell merged 1 commit intomainfrom
rf/feat/remove-thiserror

Conversation

@refcell
Copy link
Contributor

@refcell refcell commented Oct 25, 2024

Description

Completely removes the thiserror dependency, allowing us to publish our crates. Instead of deriving the core::error::Error type, we manually implement along with using derive_more::Display.

@refcell
Copy link
Contributor Author

refcell commented Oct 25, 2024

📚 $\text{Stack Overview}$

Pulls submitted in this stack:

This comment was automatically generated by st.

@refcell refcell requested a review from clabby as a code owner October 25, 2024 16:25
@refcell refcell self-assigned this Oct 25, 2024
@refcell refcell force-pushed the rf/feat/remove-thiserror branch from e0aea66 to 3cb7e3e Compare October 25, 2024 16:38
@refcell refcell added K-feature Kind: feature A-workspace Area: workspace level modifications F-deps Flag: Updates dependencies labels Oct 25, 2024
@codecov
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 14.11765% with 73 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@330deeb). Learn more about missing BASE report.
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/derive/src/errors.rs 30.7% 27 Missing ⚠️
crates/executor/src/errors.rs 0.0% 19 Missing ⚠️
crates/preimage/src/errors.rs 0.0% 11 Missing ⚠️
crates/derive/src/batch/span_batch/errors.rs 0.0% 8 Missing ⚠️
crates/mpt/src/errors.rs 0.0% 8 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@refcell refcell added this pull request to the merge queue Oct 25, 2024
Merged via the queue into main with commit 89a69a4 Oct 25, 2024
@github-actions github-actions bot mentioned this pull request Oct 25, 2024
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Dec 10, 2025
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Jan 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A-workspace Area: workspace level modifications F-deps Flag: Updates dependencies K-feature Kind: feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants