This repository was archived by the owner on Jan 16, 2026. It is now read-only.
Conversation
clabby
added
W-holocene
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files☔ View full report in Codecov by Sentry. |
clabby
force-pushed
the
cl/batch-sequencer
branch
4 times, most recently
from
f842945 to
084e7f1
Compare
clabby
force-pushed
the
cl/batch-sequencer
branch
from
f25c54f to
30c78f5
Compare
refcell
approved these changes
Oct 19, 2024
Contributor
refcell
left a comment
refcell
left a comment
There was a problem hiding this comment.
Looks good but it seems like there's a lot of duplicate logic with the batch_queue. Is it not possible to de-dup into a split out validator that holds the l1 blocks? Happy to allow any enhancements to be follow on since this works.
Merged
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Dec 10, 2025
* feat(derive): `BatchValidator` stage * tests * lint * tests tests * 🧹 * tests * lint
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Jan 14, 2026
* feat(derive): `BatchValidator` stage * tests * lint * tests tests * 🧹 * tests * lint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Adds a new stage to take place of the
BatchQueueafter Holocene activation, theBatchValidator. This stage's only role is to consume theSingleBatches from theBatchStream, validate them, and send them off to theAttributesQueue.This PR does not hook this stage up to a multiplexer stage with the
BatchQueue, and that will be done in a follow-up.