Skip to content
This repository was archived by the owner on Jan 16, 2026. It is now read-only.

chore(workspace): Removes Primitives#638

Merged
refcell merged 2 commits intomainfrom
rf/feat/remove-primitives
Oct 18, 2024
Merged

chore(workspace): Removes Primitives#638
refcell merged 2 commits intomainfrom
rf/feat/remove-primitives

Conversation

@refcell
Copy link
Contributor

@refcell refcell commented Oct 6, 2024

Description

Removes kona-primitives, in favor of upstream alloy types.

Metadata

Closes #516

@refcell refcell requested a review from clabby October 6, 2024 14:10
@refcell refcell self-assigned this Oct 6, 2024
@refcell refcell changed the title feat(workspace): Removes Primitives chore(workspace): Removes Primitives Oct 6, 2024
@codecov
Copy link

codecov bot commented Oct 6, 2024

Codecov Report

Attention: Patch coverage is 71.02804% with 62 lines in your changes missing coverage. Please review.

Project coverage is 94.2%. Comparing base (6b6a881) to head (dde88b7).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/derive/src/sources/blobs.rs 65.1% 61 Missing ⚠️
crates/derive/src/batch/span_batch/transactions.rs 50.0% 1 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@refcell refcell force-pushed the rf/feat/remove-primitives branch from 634c59a to 54ec4f3 Compare October 8, 2024 21:35
@refcell
Copy link
Contributor Author

refcell commented Oct 8, 2024

Codecov isn't updating with the rebase... it's 91.5% on codecov.io

@refcell refcell force-pushed the rf/feat/remove-primitives branch from 4cf20d9 to 364a8d8 Compare October 10, 2024 14:23
@refcell refcell force-pushed the rf/feat/remove-primitives branch 2 times, most recently from d0f654a to f5ab6fd Compare October 18, 2024 15:16
@refcell refcell force-pushed the rf/feat/remove-primitives branch from aa6d626 to 2cba579 Compare October 18, 2024 15:33
@refcell refcell requested a review from clabby October 18, 2024 17:38
Copy link
Contributor

@clabby clabby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's finally here wowowow

Send it - would be nice to get some tickets up for the cleanups to follow:

  1. Move Beacon API response types to alloy-rpc-beacon
  2. Coverage on blob decoding (this actually feels like a great candidate for op-alloy-protocol, given our blob encoding is a consensus construct.)

@refcell refcell added this pull request to the merge queue Oct 18, 2024
Merged via the queue into main with commit 2bd0928 Oct 18, 2024
This was referenced Oct 18, 2024
@github-actions github-actions bot mentioned this pull request Jan 26, 2025
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Dec 10, 2025
* feat(workspace): remove primitives

* fix: indexed blob hash
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Jan 14, 2026
* feat(workspace): remove primitives

* fix: indexed blob hash
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

K-chore Kind: chore

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(primitives): Use Alloy Blob Sidecar Type

2 participants