This repository was archived by the owner on Jan 16, 2026. It is now read-only.
fix(executor): Holocene EIP-1559 params in Header#622
Merged
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files☔ View full report in Codecov by Sentry. |
refcell
approved these changes
Oct 4, 2024
clabby
force-pushed
the
cl/bf-params-fix
branch
from
ac8d351 to
197b616
Compare
clabby
force-pushed
the
cl/bf-params-fix
branch
from
197b616 to
24cac36
Compare
This was referenced Oct 4, 2024
Closed
Closed
Closed
Closed
Closed
This was referenced Oct 9, 2024
Closed
Closed
Closed
Merged
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Dec 10, 2025
* fix(executor): Holocene EIP-1559 params in Header * throw if params are missing post-holocene * fix attributes builder + fmt * tests * sent `B64::ZERO` for the first holocene block lin * simplify branch
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Jan 14, 2026
* fix(executor): Holocene EIP-1559 params in Header * throw if params are missing post-holocene * fix attributes builder + fmt * tests * sent `B64::ZERO` for the first holocene block lin * simplify branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixes the inclusion of the current block's base fee parameters within the Header. As-is, it always includes the payload attributes' EIP-1559 parameters in the header, but this is not the desired result.
Instead, we should be including the EIP-1559 parameters that were selected for the block. That is, if the parent header's
noncefield isB64::ZERO, we should be including the canyon base fee parameters in theHeader, not what was sent through thePayloadAttributes.In addition, the attributes builder must send a zero'd out EIP1559params in the payload if the
SystemConfigdoes not yet have a view of the EIP-1559 params.