This repository was archived by the owner on Jan 16, 2026. It is now read-only.
Merged
Conversation
refcell
force-pushed
the
rf/feat/frame-queue-asserter
branch
from
db7f2e2 to
90dc6e3
Compare
refcell
force-pushed
the
rf/feat/frame-queue-asserter
branch
from
90dc6e3 to
67a25ed
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files☔ View full report in Codecov by Sentry. |
clabby
approved these changes
Oct 21, 2024
Merged
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Dec 10, 2025
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Cleans up
FrameQueuetesting by creating an assertion utility and convenience frame macros.I think we ought to clean up testing by building test utils in the top level
kona_derive::test_utilsmodule such that unit tests next to implementations are lean and concise. This way,kona_deriveisn't littered with a bunch oftest_utilsmodules nested in various sub-modules, but one comprehensive module at the top level, that can be placed behind thetest-utilsfeature flag.