Skip to content
This repository was archived by the owner on Jan 16, 2026. It is now read-only.

feat(derive): BatchStream buffering#590

Merged
clabby merged 4 commits intomainfrom
cl/fix-batch-stream
Sep 30, 2024
Merged

feat(derive): BatchStream buffering#590
clabby merged 4 commits intomainfrom
cl/fix-batch-stream

Conversation

@clabby
Copy link
Contributor

@clabby clabby commented Sep 30, 2024

Overview

Implements the rest of the BatchStream, buffering the span batch that is received and sending only SingleBatches to the batch queue.

@clabby clabby added K-feature Kind: feature A-proof Area: proof crates labels Sep 30, 2024
@clabby clabby self-assigned this Sep 30, 2024
@clabby clabby marked this pull request as draft September 30, 2024 19:13
@codecov
Copy link

codecov bot commented Sep 30, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 99.10714% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.1%. Comparing base (ed6f8f9) to head (5f5c3fc).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/derive/src/stages/batch_stream.rs 99.1% 1 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clabby clabby marked this pull request as ready for review September 30, 2024 19:29
@clabby clabby requested a review from refcell September 30, 2024 19:38
@refcell
Copy link
Contributor

refcell commented Sep 30, 2024

Dawg: #576

@refcell
Copy link
Contributor

refcell commented Sep 30, 2024

Assignee: #559

@clabby
Copy link
Contributor Author

clabby commented Sep 30, 2024 •
edited
Loading

Dawg: #576

oop, mb - thought this was something different, closing. Need this for #561

@clabby clabby closed this Sep 30, 2024
@clabby clabby reopened this Sep 30, 2024
@clabby clabby force-pushed the cl/fix-batch-stream branch from 9b7eef7 to 8ea6783 Compare September 30, 2024 21:14
@clabby Graphite App
Copy link
Contributor Author

clabby commented Sep 30, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @clabby and the rest of your teammates on Graphite Graphite

@clabby clabby mentioned this pull request Sep 30, 2024
Merged
@clabby clabby added this pull request to the merge queue Sep 30, 2024
Merged via the queue into main with commit 40a47f0 Sep 30, 2024
This was referenced Sep 30, 2024
Closed
Closed
Closed
Closed
Closed
This was referenced Oct 8, 2024
Closed
Closed
This was referenced Oct 9, 2024
Closed
Closed
Closed
@github-actions github-actions bot mentioned this pull request Oct 19, 2024
Merged
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Dec 10, 2025
@clabby
feat(derive): BatchStream buffering (op-rs/kona#590)
add0077 
* feat(derive): `BatchStream` buffering

* tests

* rebase

* lint
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Jan 14, 2026
@clabby
feat(derive): BatchStream buffering (op-rs/kona#590)
3342fe5 
* feat(derive): `BatchStream` buffering

* tests

* rebase

* lint
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@refcell refcell refcell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@clabby clabby

Labels

A-proof Area: proof crates K-feature Kind: feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@clabby @refcell