This repository was archived by the owner on Jan 16, 2026. It is now read-only.
chore(derive): [Holocene] Drain previous channel in one iteration#583
Merged
chore(derive): [Holocene] Drain previous channel in one iteration#583
Conversation
Contributor
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files☔ View full report in Codecov by Sentry. |
clabby
changed the title
refcell
reviewed
Sep 30, 2024
Contributor
There was a problem hiding this comment.
The logic makes sense to me and I like the short variable rename to prev_frame and next_frame - much clearer.
I would like to verify that it passes tests that cover the sad path ruleset where frames with differing channels are interleaved in #585.
Maybe we can merge #585 and then rebase this on-top?
refcell
approved these changes
Sep 30, 2024
This was referenced Sep 30, 2024
Closed
Closed
Closed
Closed
This was referenced Oct 7, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Merged
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Dec 10, 2025
…-rs/kona#583) * fix(derive): Holocene frame queue drain * lint * fix: bad rebase * fix: bad rebase --------- Co-authored-by: refcell <abigger87@gmail.com>
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Jan 14, 2026
…-rs/kona#583) * fix(derive): Holocene frame queue drain * lint * fix: bad rebase * fix: bad rebase --------- Co-authored-by: refcell <abigger87@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Drains the entire previous channel at one time, rather than over multiple iterations, if the following case is met:
Also fixes a small issue w/ the
DERIVED_FRAMES_COUNTmetric's accounting, where it was counting dropped frames.Tests
Added a new test for this functionality, when there is a valid, closed channel earlier on in the frame queue @
test_holocene_replace_channel.