Skip to content
This repository was archived by the owner on Jan 16, 2026. It is now read-only.

feat(derive): Holocene Buffer Flushing#575

Merged
refcell merged 2 commits intomainfrom
rf/bs-flush
Sep 27, 2024
Merged

feat(derive): Holocene Buffer Flushing#575
refcell merged 2 commits intomainfrom
rf/bs-flush

Conversation

@refcell
Copy link
Contributor

@refcell refcell commented Sep 26, 2024 •
edited
Loading

Description

Small PR to add buffer flushing to the batch stream.

@refcell refcell mentioned this pull request Sep 26, 2024
Merged
@refcell Graphite App
Copy link
Contributor Author

refcell commented Sep 26, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @refcell and the rest of your teammates on Graphite Graphite

@refcell refcell mentioned this pull request Sep 26, 2024
Merged
@refcell refcell changed the title feat(derive): holocene buffer flushing feat(derive): Holocene Buffer Flushing Sep 26, 2024
@refcell refcell requested a review from clabby September 26, 2024 13:51
@refcell refcell added A-proof Area: proof crates W-holocene Workstream: Holocene K-feature Kind: feature labels Sep 26, 2024 — with Graphite App
@refcell refcell marked this pull request as ready for review September 26, 2024 13:51
@codecov
Copy link

codecov bot commented Sep 26, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 9.09091% with 10 lines in your changes missing coverage. Please review.

Project coverage is 78.4%. Comparing base (a610b16) to head (a222220).
Report is 5 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/derive/src/stages/batch_stream.rs 0.0% 5 Missing ⚠️
crates/derive/src/pipeline/builder.rs 0.0% 2 Missing ⚠️
crates/derive/src/stages/channel_reader.rs 0.0% 2 Missing ⚠️
crates/derive/src/stages/batch_queue.rs 50.0% 1 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@refcell refcell self-assigned this Sep 26, 2024
@refcell refcell mentioned this pull request Sep 26, 2024
Closed
clabby
clabby approved these changes Sep 26, 2024
View reviewed changes
@refcell refcell force-pushed the rf/feat/wire-up-batch-span-stage branch 2 times, most recently from 6af6cdd to dac37f6 Compare September 26, 2024 19:19
@refcell refcell changed the base branch from rf/feat/wire-up-batch-span-stage to main September 26, 2024 22:05
@refcell refcell added this pull request to the merge queue Sep 27, 2024
Merged via the queue into main with commit ccd3f14 Sep 27, 2024
This was referenced Sep 27, 2024
Closed
Closed
Closed
This was referenced Oct 5, 2024
Closed
Closed
Closed
Closed
Closed
This was referenced Oct 9, 2024
Closed
Closed
@github-actions github-actions bot mentioned this pull request Oct 19, 2024
Merged
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Dec 10, 2025
@refcell
feat(derive): Holocene Buffer Flushing (op-rs/kona#575)
644c970 
* feat(derive): wire up the batch span stage (op-rs/kona#567)

* fix: missing flush
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Jan 14, 2026
@refcell
feat(derive): Holocene Buffer Flushing (op-rs/kona#575)
d1fb93e 
* feat(derive): wire up the batch span stage (op-rs/kona#567)

* fix: missing flush
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@clabby clabby clabby approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@refcell refcell

Labels

A-proof Area: proof crates K-feature Kind: feature W-holocene Workstream: Holocene

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@refcell @clabby