This repository was archived by the owner on Jan 16, 2026. It is now read-only.
feat(derive): Holocene Channel Bank Checks#572
Merged
Conversation
Contributor
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
refcell
changed the title
refcell
added
A-proof
Graphite App
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files☔ View full report in Codecov by Sentry. |
clabby
approved these changes
Sep 27, 2024
Contributor
clabby
left a comment
clabby
left a comment
There was a problem hiding this comment.
This LGTM. It'd be nice to add a quick unit test that covers the case where the channel queue is cleared, when a new frame is sent during an existing channel's buffer period.
refcell
force-pushed
the
rf/feat/channel-bank-checks
branch
from
69d1462 to
350460f
Compare
refcell
force-pushed
the
rf/feat/channel-bank-checks
branch
from
544c08e to
082fdb2
Compare
This was referenced Sep 27, 2024
Closed
Closed
Closed
Closed
This was referenced Oct 5, 2024
Closed
Closed
Closed
Closed
Closed
Closed
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Dec 10, 2025
* feat(derive): holocene channel bank checks * fix(ci): stack overflow
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Jan 14, 2026
* feat(derive): holocene channel bank checks * fix(ci): stack overflow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds checks to the
ChannelBankfor post-holocene strict ordering that only one channel may only be buffered at a given point in time within the channel queue.Closes #558