This repository was archived by the owner on Jan 16, 2026. It is now read-only.
fix(preimage): Improve error differentiation in preimage servers#535
Merged
fix(preimage): Improve error differentiation in preimage servers#535
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files☔ View full report in Codecov by Sentry. |
clabby
changed the title
refcell
approved these changes
Sep 18, 2024
This was referenced Sep 27, 2024
Closed
Closed
Closed
This was referenced Oct 5, 2024
Closed
Closed
Closed
Closed
Closed
Closed
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Dec 10, 2025
…rs/kona#535) * chore(preimage): Improve error differentiation in preimage servers * test unblock on failure for hintrouter * assert err * fix bad utf8 unblocking
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Jan 14, 2026
…rs/kona#535) * chore(preimage): Improve error differentiation in preimage servers * test unblock on failure for hintrouter * assert err * fix bad utf8 unblocking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Improves the differentiation of errors in the preimage server routes. This allows for us to throw on non-pipe related errors, rather than silently fail and assume that the exit is related to a broken pipe.
Also fixes an edge case where if the
HintReaderServerreceives bad UTF-8, it will block forever.