Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests failing on 1.1 #4

Closed
KristofferC opened this issue Dec 13, 2018 · 2 comments
Closed

Tests failing on 1.1 #4

KristofferC opened this issue Dec 13, 2018 · 2 comments

Comments

@KristofferC
Copy link

KristofferC commented Dec 13, 2018

Hello, we are running tests against all registered packages in preparation of the 1.1 release (JuliaLang/julia#30374). We noticed that your package started failing on 1.1 (but was working on 1.0.x). The reason for the failure is this line

@test iterate(dr) == (first(dr),1)
explicitly tests the state of the step range (which has been changed on 1.1). Relying on the exact form of the state for iterators is not advisable and one should try to use the iterator interface instead.

The package seems to still work fine, it is just the tests that are a bit too explicit.

@antimon2
Copy link
Owner

Thank you for your report.
I understand the circumstances.
I will fix (or invalidate) the test in the near future.

@antimon2
Copy link
Owner

antimon2 commented Jan 4, 2019

@KristofferC
I released QDates.jl v0.2.0.
There are some fixes including this issue.

@antimon2 antimon2 closed this as completed Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants