Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readme code example should mention the importance of gamma correction. #70

Open
Zyl9393 opened this issue Jul 13, 2019 · 2 comments
Open

Readme code example should mention the importance of gamma correction. #70

Zyl9393 opened this issue Jul 13, 2019 · 2 comments

Comments

@Zyl9393
Copy link

Zyl9393 commented Jul 13, 2019 •
edited
Loading

Gamma correction is among the things most often done wrong by graphics programming novices. It's almost as bad as missing scene-related color transforms and linear volume sliders in the average video game. The code example in the readme should definitely mention to adjust.Gamma(img, 1/2.2) before doing any color mixing and adjust.Gamma(img, 2.2) before saving back to file (for as long as bild does not implicitly handle this, anyway) and link to some recommended reading.
@Zyl9393 Zyl9393 changed the title Readme code example should mention gamma correction. Readme code example should mention the importance of gamma correction. Jul 13, 2019
@dolmen
Copy link

dolmen commented Jul 30, 2019

@Zyl9393 Could you link to your own "recommended reading"?

@Zyl9393
Copy link
Author

Zyl9393 commented Jul 30, 2019

@dolmen How about an edutainment video?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dolmen @Zyl9393