Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(layout): 统一 PageContainer 计算到 styles.ts 中 #7699

Merged
merged 11 commits into from
Sep 22, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
uses: pnpm/action-setup@v2
with:
version: 8.6.7
- run: pnpm install --no-frozen-lockfile
- run: pnpm install
- run: pnpm run build
env:
PRO_COMPONENTS_CI: CI
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/coverage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
with:
version: 8.6.7

- run: pnpm install --no-frozen-lockfile
- run: pnpm install
if: |
steps.cache-pnpm-cache.outputs.cache-hit != 'true' ||
steps.cache-node-modules.outputs.cache-hit != 'true'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/preview-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
env:
TEST_UI: 'preview'
run: |
pnpm install --no-frozen-lockfile
pnpm install
pnpm run build
pnpm run dumi

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"start": "npm run version && dumi dev",
"sync:tnpm": "node -e 'require(\"./scripts/syncTNPM\")()'",
"test": "npm run version && cross-env TZ=UTC vitest",
"test:coverage": "npm run version && cross-env TZ=UTC TEST_LOG=none vitest --threads=false --coverage",
"test:coverage": "npm run version && cross-env TZ=UTC TEST_LOG=none vitest --coverage",
"test:update": "pnpm run version && cross-env TZ=UTC vitest -u",
"tsc": "tsc --noEmit",
"tsc:duplicate": "tsc -p ./tests/tsconfig.duplicate.json",
Expand Down
9 changes: 3 additions & 6 deletions packages/form/src/components/Checkbox/index.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { runFunction } from '@ant-design/pro-utils';
import type { CheckboxProps } from 'antd';
import type { CheckboxProps, CheckboxRef } from 'antd';
import { Checkbox } from 'antd';
import type { CheckboxGroupProps } from 'antd/lib/checkbox';
import React from 'react';
Expand Down Expand Up @@ -56,18 +56,15 @@ const CheckboxGroup: React.FC<ProFormCheckboxGroupProps> = React.forwardRef(
),
);

export type ProFormCheckboxProps = ProFormFieldItemProps<
CheckboxProps,
HTMLInputElement
>;
export type ProFormCheckboxProps = ProFormFieldItemProps<CheckboxProps>;

/**
* 多选框的
*
* @param
*/
const ProFormCheckboxComponents: React.FC<ProFormCheckboxProps> =
React.forwardRef<any, ProFormCheckboxProps>(
React.forwardRef<CheckboxRef, ProFormCheckboxProps>(
({ fieldProps, children }, ref) => {
return (
<Checkbox ref={ref} {...fieldProps}>
Expand Down
2 changes: 1 addition & 1 deletion packages/form/src/layouts/DrawerForm/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,7 @@ function DrawerForm<T = Record<string, any>, U = Record<string, any>>({
const offsetRight: number | string = ((document.body.offsetWidth ||
1000) -
(e.clientX - document.body.offsetLeft)) as number | string;
const minWidth = resizeInfo?.minWidth ?? width;
const minWidth = resizeInfo?.minWidth ?? (width || 800);
const maxWidth = resizeInfo?.maxWidth ?? window.innerWidth * 0.8;

if (offsetRight < minWidth) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ export default () => (
],
}}
>
<ProTable />
<ProTable search={false} />
</PageContainer>
</div>
);
15 changes: 7 additions & 8 deletions packages/layout/src/components/PageContainer/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -165,10 +165,10 @@
>
{/* 如果版本低于 4.23.0,不支持 items */}
{compareVersions(version, '4.23.0') < 0
? tabList?.map((item, index) => {
return (

Check warning on line 169 in packages/layout/src/components/PageContainer/index.tsx

View check run for this annotation

Codecov / codecov/patch

packages/layout/src/components/PageContainer/index.tsx#L168-L169

Added lines #L168 - L169 were not covered by tests
<Tabs.TabPane
key={item.key || index}

Check warning on line 171 in packages/layout/src/components/PageContainer/index.tsx

View check run for this annotation

Codecov / codecov/patch

packages/layout/src/components/PageContainer/index.tsx#L171

Added line #L171 was not covered by tests
tab={item.tab}
{...item}
/>
Expand Down Expand Up @@ -410,15 +410,14 @@
<>
<div
className={classNames(
`${basePageContainer}-children-container ${hashId}`.trim(),
hashId,
`${basePageContainer}-children-container`,
{
[`${basePageContainer}-children-container-no-header`]:
!props?.header,
},
)}
// 没有 header 存在需要给 container 加上 BlockStart,正常时间不需要
style={{
paddingBlockStart: props?.header
? 0
: token?.layout?.pageContainer?.paddingBlockPageContainerContent,
...childrenContentStyle,
}}
style={childrenContentStyle}
>
{children}
</div>
Expand Down
5 changes: 5 additions & 0 deletions packages/layout/src/components/PageContainer/style/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,16 @@
[token.componentCls]: {
position: 'relative',
'&-children-container': {
paddingBlockStart: 0,
paddingBlockEnd:
token.layout?.pageContainer?.paddingBlockPageContainerContent,
paddingInline:
token.layout?.pageContainer?.paddingInlinePageContainerContent,
},
'&-children-container-no-header': {
paddingBlockStart:
token.layout?.pageContainer?.paddingBlockPageContainerContent,
},
'&-affix': {
[`${token.antCls}-affix`]: {
[`${token.componentCls}-warp`]: {
Expand All @@ -30,7 +35,7 @@
['& &-warp-page-header']: {
paddingBlockStart:
(token.layout?.pageContainer?.paddingBlockPageContainerContent ??
40) / 4,

Check warning on line 38 in packages/layout/src/components/PageContainer/style/index.ts

View check run for this annotation

Codecov / codecov/patch

packages/layout/src/components/PageContainer/style/index.ts#L38

Added line #L38 was not covered by tests
paddingBlockEnd:
(token.layout?.pageContainer?.paddingBlockPageContainerContent ??
40) / 2,
Expand All @@ -48,19 +53,19 @@
[`${token.antCls}-page-header-breadcrumb`]: {
paddingBlockStart:
(token.layout?.pageContainer?.paddingBlockPageContainerContent ??
40) /

Check warning on line 56 in packages/layout/src/components/PageContainer/style/index.ts

View check run for this annotation

Codecov / codecov/patch

packages/layout/src/components/PageContainer/style/index.ts#L56

Added line #L56 was not covered by tests
4 +
10,
},
[`${token.antCls}-page-header-heading`]: {
paddingBlockStart:
(token.layout?.pageContainer?.paddingBlockPageContainerContent ??
40) / 4,

Check warning on line 63 in packages/layout/src/components/PageContainer/style/index.ts

View check run for this annotation

Codecov / codecov/patch

packages/layout/src/components/PageContainer/style/index.ts#L63

Added line #L63 was not covered by tests
},
[`${token.antCls}-page-header-footer`]: {
marginBlockStart:
(token.layout?.pageContainer?.paddingBlockPageContainerContent ??
40) / 4,

Check warning on line 68 in packages/layout/src/components/PageContainer/style/index.ts

View check run for this annotation

Codecov / codecov/patch

packages/layout/src/components/PageContainer/style/index.ts#L68

Added line #L68 was not covered by tests
},
},
'&-detail': {
Expand Down
8 changes: 5 additions & 3 deletions packages/layout/src/components/SiderMenu/BaseMenu.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -546,7 +546,9 @@ const BaseMenu: React.FC<BaseMenuProps & PrivateSiderMenuProps> = (props) => {
menu?.defaultOpenAll,
);

const [openKeys, setOpenKeys] = useMountMergeState<WithFalse<React.Key[]>>(
const [openKeys, setOpenKeys] = useMountMergeState<
(string | number)[] | false
>(
() => {
if (menu?.defaultOpenAll) {
return getOpenKeysFromMenuData(menuData) || [];
Expand Down Expand Up @@ -605,7 +607,7 @@ const BaseMenu: React.FC<BaseMenuProps & PrivateSiderMenuProps> = (props) => {
propsOpenKeys !== false &&
matchMenuKeys.join('-') !== (openKeys || []).join('-')
) {
let newKeys: React.Key[] = matchMenuKeys;
let newKeys: (string | number)[] | false = matchMenuKeys;
// 如果不自动关闭,我需要把 openKeys 放进去
if (menu?.autoClose === false) {
newKeys = Array.from(
Expand Down Expand Up @@ -697,7 +699,7 @@ const BaseMenu: React.FC<BaseMenuProps & PrivateSiderMenuProps> = (props) => {
[`${baseClassName}-collapsed`]: props.collapsed,
})}
items={menuUtils.getNavMenuItems(finallyData, 0)}
onOpenChange={(_openKeys: React.Key[]) => {
onOpenChange={(_openKeys) => {
if (!props.collapsed) {
setOpenKeys(_openKeys);
}
Expand Down
18 changes: 9 additions & 9 deletions packages/layout/src/components/WaterMark/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@
rotate = -22, // 默认旋转 -22 度
image,
offsetLeft,
offsetTop,
offsetTop: outOffsetTop,
fontStyle = 'normal',
fontWeight = 'normal',
fontColor = token.colorFill,
Expand All @@ -108,7 +108,7 @@
const canvasWidth = `${(gapX + width) * ratio}px`;
const canvasHeight = `${(gapY + height) * ratio}px`;
const canvasOffsetLeft = offsetLeft || gapX / 2;
const canvasOffsetTop = offsetTop || gapY / 2;
const canvasOffsetTop = outOffsetTop || gapY / 2;

canvas.setAttribute('width', canvasWidth);
canvas.setAttribute('height', canvasHeight);
Expand All @@ -119,6 +119,12 @@
return;
}

// 旋转字符 rotate
ctx.translate(canvasOffsetLeft * ratio, canvasOffsetTop * ratio);
ctx.rotate((Math.PI / 180) * Number(rotate));
const markWidth = width * ratio;
const markHeight = height * ratio;

const writeContent = (
contentText: string | string[],
offsetTop: number = 0,
Expand All @@ -136,12 +142,6 @@
setBase64Url(canvas.toDataURL());
};

// 旋转字符 rotate
ctx.translate(canvasOffsetLeft * ratio, canvasOffsetTop * ratio);
ctx.rotate((Math.PI / 180) * Number(rotate));
const markWidth = width * ratio;
const markHeight = height * ratio;

if (image) {
const img = new Image();
img.crossOrigin = 'anonymous';
Expand All @@ -151,8 +151,8 @@
ctx.drawImage(img, 0, 0, markWidth, markHeight);
setBase64Url(canvas.toDataURL());
if (props.content) {
writeContent(props.content, img.height + 8);
return;

Check warning on line 155 in packages/layout/src/components/WaterMark/index.tsx

View check run for this annotation

Codecov / codecov/patch

packages/layout/src/components/WaterMark/index.tsx#L154-L155

Added lines #L154 - L155 were not covered by tests
}
};
return;
Expand All @@ -165,7 +165,7 @@
gapX,
gapY,
offsetLeft,
offsetTop,
outOffsetTop,
rotate,
fontStyle,
fontWeight,
Expand Down
6 changes: 2 additions & 4 deletions packages/list/src/demos/expand.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { ProList } from '@ant-design/pro-components';
import { Button, Progress, Space, Tag } from 'antd';
import type { ReactText } from 'react';
import type { Key } from 'react';
import { useState } from 'react';

const dataSource = [
Expand All @@ -27,9 +27,7 @@ const dataSource = [
];

export default () => {
const [expandedRowKeys, setExpandedRowKeys] = useState<readonly ReactText[]>(
[],
);
const [expandedRowKeys, setExpandedRowKeys] = useState<readonly Key[]>([]);

return (
<ProList<{ title: string }>
Expand Down
6 changes: 3 additions & 3 deletions packages/list/src/demos/selectedRow.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { ProList } from '@ant-design/pro-components';
import { Button, Progress } from 'antd';
import type { ReactText } from 'react';
import type { Key } from 'react';
import { useState } from 'react';

const dataSource = [
Expand All @@ -27,10 +27,10 @@ const dataSource = [
];

export default () => {
const [selectedRowKeys, setSelectedRowKeys] = useState<ReactText[]>([]);
const [selectedRowKeys, setSelectedRowKeys] = useState<Key[]>([]);
const rowSelection = {
selectedRowKeys,
onChange: (keys: ReactText[]) => setSelectedRowKeys(keys),
onChange: (keys: Key[]) => setSelectedRowKeys(keys),
};

return (
Expand Down
10 changes: 4 additions & 6 deletions packages/list/src/demos/size.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { ProList } from '@ant-design/pro-components';
import { Button, Progress, Select } from 'antd';
import type { ReactText } from 'react';
import type { Key } from 'react';
import { useState } from 'react';

const dataSource = [
Expand All @@ -27,17 +27,15 @@ const dataSource = [
];

export default () => {
const [selectedRowKeys, setSelectedRowKeys] = useState<ReactText[]>([]);
const [expandedRowKeys, setExpandedRowKeys] = useState<readonly ReactText[]>(
[],
);
const [selectedRowKeys, setSelectedRowKeys] = useState<Key[]>([]);
const [expandedRowKeys, setExpandedRowKeys] = useState<readonly Key[]>([]);
const [size, setSize] = useState<'small' | 'default' | 'large' | undefined>(
'default',
);
const [split, setSplit] = useState<0 | 1>(1);
const rowSelection = {
selectedRowKeys,
onChange: (keys: ReactText[]) => setSelectedRowKeys(keys),
onChange: (keys: Key[]) => setSelectedRowKeys(keys),
};

return (
Expand Down
10 changes: 4 additions & 6 deletions packages/list/src/demos/special.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { EllipsisOutlined } from '@ant-design/icons';
import { ProList } from '@ant-design/pro-components';
import { Button, Progress, Tag } from 'antd';
import type { ReactText } from 'react';
import type { Key } from 'react';
import { useState } from 'react';

const types = ['top', 'inline', 'new'];
Expand Down Expand Up @@ -51,13 +51,11 @@ const data = [
}));

export default () => {
const [expandedRowKeys, setExpandedRowKeys] = useState<readonly ReactText[]>(
[],
);
const [selectedRowKeys, setSelectedRowKeys] = useState<ReactText[]>([]);
const [expandedRowKeys, setExpandedRowKeys] = useState<readonly Key[]>([]);
const [selectedRowKeys, setSelectedRowKeys] = useState<Key[]>([]);
const rowSelection = {
selectedRowKeys,
onChange: (keys: ReactText[]) => setSelectedRowKeys(keys),
onChange: (keys: Key[]) => setSelectedRowKeys(keys),
};
const [dataSource, setDataSource] = useState<any[]>([...data] as any[]);

Expand Down
6 changes: 3 additions & 3 deletions packages/list/src/demos/testConfigProvider.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { ProList } from '@ant-design/pro-components';
import { ConfigProvider, Progress } from 'antd';
import type { ReactText } from 'react';
import type { Key } from 'react';
import { useState } from 'react';

const dataSource = [
Expand All @@ -12,10 +12,10 @@ const dataSource = [
];

export default () => {
const [selectedRowKeys, setSelectedRowKeys] = useState<ReactText[]>([]);
const [selectedRowKeys, setSelectedRowKeys] = useState<Key[]>([]);
const rowSelection = {
selectedRowKeys,
onChange: (keys: ReactText[]) => setSelectedRowKeys(keys),
onChange: (keys: Key[]) => setSelectedRowKeys(keys),
};

return (
Expand Down
2 changes: 1 addition & 1 deletion packages/provider/src/intl.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,10 @@ import skSK from './locale/sk_SK';
import srRS from './locale/sr_RS';
import thTH from './locale/th_TH';
import trTR from './locale/tr_TR';
import ukUA from './locale/uk_UA';
import viVN from './locale/vi_VN';
import zhCN from './locale/zh_CN';
import zhTW from './locale/zh_TW';
import ukUA from './locale/uk_UA';

/**
* 安全的从一个对象中读取相应的值
Expand Down
6 changes: 3 additions & 3 deletions packages/provider/src/locale/uk_UA.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,9 @@ export default {
densitySmall: 'Стислий',
},
stepsForm: {
next: 'Наступний',
prev: 'Попередній',
submit: 'Завершити',
next: 'Наступний',
prev: 'Попередній',
submit: 'Завершити',
},
loginForm: {
submitText: 'Вхіх',
Expand Down
4 changes: 2 additions & 2 deletions packages/table/src/Store/Provide.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import {
} from 'react';
import type { DensitySize } from '../components/ToolBar/DensityIcon';
import type { ProTableProps } from '../index';
import type { ActionType } from '../typing';
import type { ActionType, ProColumns } from '../typing';
import { genColumnKey } from '../utils';

export type ColumnsState = {
Expand All @@ -33,7 +33,7 @@ export type UseContainerProps<T = any> = {
size?: DensitySize;
defaultSize?: DensitySize;
onSizeChange?: (size: DensitySize) => void;
columns?: ProTableColumn<T>[];
columns?: ProTableColumn<T>[] | ProColumns<T, T>[];
columnsState?: ProTableProps<any, any, any>['columnsState'];
};

Expand Down
5 changes: 3 additions & 2 deletions packages/table/src/Table.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ import type {
import classNames from 'classnames';
import type Summary from 'rc-table/lib/Footer/Summary';
import React, {
Key,
useCallback,
useContext,
useEffect,
Expand Down Expand Up @@ -478,7 +479,7 @@ const ProTable = <

/** 单选多选的相关逻辑 */
const [selectedRowKeys, setSelectedRowKeys] = useMountMergeState<
(string | number)[] | undefined
(string | number)[] | Key[] | undefined
>(
propsRowSelection
? propsRowSelection?.defaultSelectedRowKeys || []
Expand Down Expand Up @@ -692,7 +693,7 @@ const ProTable = <
setSelectedRowKeys([]);
}, [propsRowSelection, setSelectedRowKeys]);

counter.propsRef.current = props;
counter.propsRef.current = props as ProTableProps<any, any, any>;

/** 可编辑行的相关配置 */
const editableUtils = useEditableArray<any>({
Expand Down
Loading
Loading