Use backwards incompatible change from ansible-compat 4.0.1 #3904

asmacdo · 2023-05-01T18:29:19Z

Fixes #3903

ansible/ansible-compat#256

I made this change direct in my site-packages and it fixed the issue i was having. (3903)

Let me know if it needs anything else!

asmacdo · 2023-05-01T18:51:46Z

Bump to ansible-compat 4.0.1 causes other dependency issues. I guess we could require ansible-compat<=4.0.0

I'll wait for a maintainer to suggest what to do next. (I'm happy to do it, but if you'd rather not wait go ahead :)

test some molecule THINGS (see ansible-community/molecule-plugins#148, ansible/molecule#3904)

* change openvpn push information * add molecule test for unconfigured role test some molecule THINGS (see ansible-community/molecule-plugins#148, ansible/molecule#3904)

There is an improperly handled breaking change in ansible-compat, which causes a malfunction in molecule. As a result, you should enforce the usage of ansible-compat==3.0.1 instead of version 4.0.1 (at least until the necessary fix is provided in molecule ansible/molecule#3904 ).

ssbarnea · 2023-05-03T13:50:44Z

@asmacdo Please continue on this, we do want to switch to the new version and the API changes are not so many, mainly is about switching to Path objects for paths and exec being renamed to run.

For the moment I made a v.5.0.1 hotfix which prevents used of newer compat, at least until we can get your fix in.

git clean -xdf tar zcvf ../python-molecule_5.0.1.orig.tar.gz --exclude=.git . debuild -uc -us cp python-molecule.spec ../python-molecule_5.0.1-1.spec mv ../python*-molecule*5.0.1*.{gz,xz,spec,dsc} /osc/home\:alvistack/ansible-community-molecule-5.0.1/ rm -rf ../python*-molecule*5.0.1*.* See ansible#3904 Signed-off-by: Wong Hoi Sing Edison <[email protected]>

git clean -xdf tar zcvf ../python-molecule_5.0.0.orig.tar.gz --exclude=.git . debuild -uc -us cp python-molecule.spec ../python-molecule_5.0.0-1.spec mv ../python*-molecule*5.0.0*.{gz,xz,spec,dsc} /osc/home\:alvistack/ansible-community-molecule-5.0.0/ rm -rf ../python*-molecule*5.0.0*.* See ansible#3904 Signed-off-by: Wong Hoi Sing Edison <[email protected]>

git clean -xdf tar zcvf ../python-molecule_5.0.1.orig.tar.gz --exclude=.git . debuild -uc -us cp python-molecule.spec ../python-molecule_5.0.1-1.spec mv ../python*-molecule*5.0.1*.{gz,xz,spec,dsc} /osc/home\:alvistack/ansible-community-molecule-5.0.1/ rm -rf ../python*-molecule*5.0.1*.* See ansible#3904 Signed-off-by: Wong Hoi Sing Edison <[email protected]>

asmacdo · 2023-05-08T15:57:41Z

@ssbarnea I think we're good to merge!

git clean -xdf tar zcvf ../python-molecule_5.0.0.orig.tar.gz --exclude=.git . debuild -uc -us cp python-molecule.spec ../python-molecule_5.0.0-1.spec mv ../python*-molecule*5.0.0*.{gz,xz,spec,dsc} /osc/home\:alvistack/ansible-community-molecule-5.0.0/ rm -rf ../python*-molecule*5.0.0*.* See ansible#3904 Signed-off-by: Wong Hoi Sing Edison <[email protected]>

git clean -xdf tar zcvf ../python-molecule_5.0.1.orig.tar.gz --exclude=.git . debuild -uc -us cp python-molecule.spec ../python-molecule_5.0.1-1.spec mv ../python*-molecule*5.0.1*.{gz,xz,spec,dsc} /osc/home\:alvistack/ansible-community-molecule-5.0.1/ rm -rf ../python*-molecule*5.0.1*.* See ansible#3904 Signed-off-by: Wong Hoi Sing Edison <[email protected]>

ziegenberg · 2023-06-05T15:32:25Z

I think, as soon as we have ansible-compat 4.1.2 in here it's good to go.

.config/requirements.in

ansible-compat 4.0.1 included a breaking change. If we want to use latest, minimum version must be at least 4.0.1. ansible-compat < 4.1.2 has an issue that causes an unhandled exception for certain log levels. ansible/ansible-lint#3522 Since this issue caused CI trouble, we go ahead and bump to 4.1.2.

=== Do not change lines below === { "chain": [], "cmd": "pip-compile --no-annotate --output-file=.config/requirements-lock.txt --resolver=backtracking --strip-extras --unsafe-package=ruamel-yaml-clib pyproject.toml", "exit": 0, "extra_inputs": [], "inputs": [], "outputs": [], "pwd": "." } ^^^ Do not change lines above ^^^

Currently the tests fail for `test_command_init_role` and `test_command_init_scneario`. The tests execute `ansible-lint` on the newly-created roles and the linter recently got more restrictive, so we now have to adapt.

asmacdo · 2023-06-05T16:59:37Z

bumped, recompiled requirements, rebased. Should be good to go if CI is happy 🤞

ty @zhan9san @ziegenberg

ziegenberg · 2023-06-05T17:03:06Z

Did you miss updating .config/requirements.txt?

ziegenberg · 2023-06-06T11:18:24Z

@asmacdo could you have a look and fix the CI problems?

=== Do not change lines below === { "chain": [], "cmd": "pip-compile --extra=docs --extra=test --no-annotate --output-file=.config/requirements.txt --resolver=backtracking --strip-extras pyproject.toml", "exit": 0, "extra_inputs": [], "inputs": [], "outputs": [], "pwd": "." } ^^^ Do not change lines above ^^^

ziegenberg

@asmacdo CI is now almost happy.

.config/requirements-lock.txt

.config/requirements.txt

I used 3.10, but CI will run this on 3.9, and fail if there is a diff. This means it is safe to change this by hand, since it will be checked.

alessfg · 2023-06-19T16:19:59Z

Any chance you could create a new release to allow us to use the latest versions of Molecule and Ansible Lint simultaneously? 😄

hswong3i · 2023-06-20T01:28:07Z

@alessfg you may manually patch the installed molecule v5.0.1, e.g.

$ sudo -E podman run -ti --rm ubuntu:22.04 bash

root@38a5c29f4af4:/# apt update && apt -y full-upgrade && apt -y install python3-dev python3-pip python3-venv patchutils curl

root@38a5c29f4af4:/# pip install pipx

root@38a5c29f4af4:/# pipx install --include-deps molecule

root@38a5c29f4af4:/# cd /root/.local/pipx/venvs/molecule/lib/python3.10/site-packages/molecule/

# We need `patch -p3 -f` here because different folder structure after install by pip
root@38a5c29f4af4:~/.local/pipx/venvs/molecule/lib/python3.10/site-packages/molecule# curl -skL https://github.com/ansible-community/molecule/pull/3904.patch | patch -p3 -f

root@38a5c29f4af4:~/.local/pipx/venvs/molecule/lib/python3.10/site-packages/molecule# fgrep -nH app.runtime.run util.py
util.py:149:    result = app.runtime.run(

Well, I had a patched version with .deb/.rpm here, if you could agree with my greedy installation method, too (use with caution, you were warned):

alessfg · 2023-06-21T17:27:40Z

I could, but it would be even nicer to get a new official release! 😛

Unfreeze when molecule >= 5.0.2 is released Links: - ansible/molecule#3926 - ansible/molecule#3904

git clean -xdf tar zcvf ../python-molecule_5.0.0.orig.tar.gz --exclude=.git . debuild -uc -us cp python-molecule.spec ../python-molecule_5.0.0-1.spec cp ../python*-molecule*5.0.0*.{gz,xz,spec,dsc} /osc/home\:alvistack/ansible-community-molecule-5.0.0/ rm -rf ../python*-molecule*5.0.0*.* See ansible#3904 Signed-off-by: Wong Hoi Sing Edison <[email protected]>

git clean -xdf tar zcvf ../python-molecule_5.0.1.orig.tar.gz --exclude=.git . debuild -uc -us cp python-molecule.spec ../python-molecule_5.0.1-1.spec cp ../python*-molecule*5.0.1*.{gz,xz,spec,dsc} /osc/home\:alvistack/ansible-community-molecule-5.0.1/ rm -rf ../python*-molecule*5.0.1*.* See ansible#3904 Signed-off-by: Wong Hoi Sing Edison <[email protected]>

git clean -xdf tar zcvf ../python-molecule_5.0.0.orig.tar.gz --exclude=.git . debuild -uc -us cp python-molecule.spec ../python-molecule_5.0.0-1.spec cp ../python*-molecule*5.0.0*.{gz,xz,spec,dsc} /osc/home\:alvistack/ansible-community-molecule-5.0.0/ rm -rf ../python*-molecule*5.0.0*.* See ansible#3904 Signed-off-by: Wong Hoi Sing Edison <[email protected]>

git clean -xdf tar zcvf ../python-molecule_5.0.1.orig.tar.gz --exclude=.git . debuild -uc -us cp python-molecule.spec ../python-molecule_5.0.1-1.spec cp ../python*-molecule*5.0.1*.{gz,xz,spec,dsc} /osc/home\:alvistack/ansible-community-molecule-5.0.1/ rm -rf ../python*-molecule*5.0.1*.* See ansible#3904 Signed-off-by: Wong Hoi Sing Edison <[email protected]>

git clean -xdf tar zcvf ../python-molecule_5.0.0.orig.tar.gz --exclude=.git . debuild -uc -us cp python-molecule.spec ../python-molecule_5.0.0-1.spec cp ../python*-molecule*5.0.0*.{gz,xz,spec,dsc} /osc/home\:alvistack/ansible-community-molecule-5.0.0/ rm -rf ../python*-molecule*5.0.0*.* See ansible#3904 Signed-off-by: Wong Hoi Sing Edison <[email protected]>

git clean -xdf tar zcvf ../python-molecule_5.0.1.orig.tar.gz --exclude=.git . debuild -uc -us cp python-molecule.spec ../python-molecule_5.0.1-1.spec cp ../python*-molecule*5.0.1*.{gz,xz,spec,dsc} /osc/home\:alvistack/ansible-community-molecule-5.0.1/ rm -rf ../python*-molecule*5.0.1*.* See ansible#3904 Signed-off-by: Wong Hoi Sing Edison <[email protected]>

asmacdo requested review from a team as code owners May 1, 2023 18:29

asmacdo requested review from Shaps, apatard, cidrblock, priyamsahoo and shatakshiiii and removed request for a team May 1, 2023 18:29

github-actions bot added the bug label May 1, 2023

bodsch added a commit to bodsch/ansible-openvpn that referenced this pull request May 2, 2023

add molecule test for unconfigured role

fcea5ee

test some molecule THINGS (see ansible-community/molecule-plugins#148, ansible/molecule#3904)

relrod mentioned this pull request May 2, 2023

[CI] Fix failing AWX checks by pinning molecule dependency ansible-compat ansible/awx-operator#1387

Merged

jpodivin mentioned this pull request May 2, 2023

Setting pin to version in order to fix issue caused by breaking chang… openstack-k8s-operators/edpm-ansible#140

Merged

ThomasSanson mentioned this pull request May 2, 2023

Use makefile for molecule tests in CI/CD vitabaks/autobase#309

Merged

dvzrv mentioned this pull request May 3, 2023

molecule broken with latest version of ansible-compat #3903

Closed

asmacdo changed the title ~~One more s/exec/run/~~ Use backwards incompatible change from ansible-compat 4.0.1 May 8, 2023

asmacdo force-pushed the fix-ansible-compat branch 3 times, most recently from 56b7b8b to d41d195 Compare May 8, 2023 15:49

ziegenberg mentioned this pull request Jun 5, 2023

fix tests for commands molecule init role and molecule init scenario #3924

Closed

ziegenberg suggested changes Jun 5, 2023

View reviewed changes

.config/requirements.in Outdated Show resolved Hide resolved

asmacdo force-pushed the fix-ansible-compat branch from 25de3e1 to 35df3d3 Compare June 5, 2023 16:56

asmacdo and others added 3 commits June 5, 2023 12:58

fixup

a794db5

fix tests for command init role and init scenario

5f0b40c

Currently the tests fail for `test_command_init_role` and `test_command_init_scneario`. The tests execute `ansible-lint` on the newly-created roles and the linter recently got more restrictive, so we now have to adapt.

asmacdo force-pushed the fix-ansible-compat branch from 35df3d3 to 5f0b40c Compare June 5, 2023 16:58

ziegenberg reviewed Jun 6, 2023

View reviewed changes

.config/requirements-lock.txt Outdated Show resolved Hide resolved

.config/requirements.txt Outdated Show resolved Hide resolved

ziegenberg mentioned this pull request Jun 6, 2023

Compatibility issue ansible-lint 6.17.0 #3927

Closed

Fake 3.9 for autogenerated files

96541ba

I used 3.10, but CI will run this on 3.9, and fail if there is a diff. This means it is safe to change this by hand, since it will be checked.

ziegenberg self-requested a review June 6, 2023 14:29

ziegenberg approved these changes Jun 6, 2023

View reviewed changes

zhan9san merged commit 3f97a41 into ansible:main Jun 7, 2023

giner added a commit to giner/ansible-role-barman that referenced this pull request Jun 22, 2023

Temporarily freeze version of ansible-lint

44afd6a

Unfreeze when molecule >= 5.0.2 is released Links: - ansible/molecule#3926 - ansible/molecule#3904

giner added a commit to giner/ansible-role-tfenv that referenced this pull request Jun 23, 2023

Temporarily freeze version of ansible-lint

0000c2f

Unfreeze when molecule >= 5.0.2 is released Links: - ansible/molecule#3926 - ansible/molecule#3904

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use backwards incompatible change from ansible-compat 4.0.1 #3904

Use backwards incompatible change from ansible-compat 4.0.1 #3904

asmacdo commented May 1, 2023

asmacdo commented May 1, 2023

ssbarnea commented May 3, 2023

asmacdo commented May 8, 2023

ziegenberg commented Jun 5, 2023

asmacdo commented Jun 5, 2023

ziegenberg commented Jun 5, 2023

ziegenberg commented Jun 6, 2023

ziegenberg left a comment

alessfg commented Jun 19, 2023

hswong3i commented Jun 20, 2023

alessfg commented Jun 21, 2023

Use backwards incompatible change from ansible-compat 4.0.1 #3904

Use backwards incompatible change from ansible-compat 4.0.1 #3904

Conversation

asmacdo commented May 1, 2023

asmacdo commented May 1, 2023

ssbarnea commented May 3, 2023

asmacdo commented May 8, 2023

ziegenberg commented Jun 5, 2023

asmacdo commented Jun 5, 2023

ziegenberg commented Jun 5, 2023

ziegenberg commented Jun 6, 2023

ziegenberg left a comment

Choose a reason for hiding this comment

alessfg commented Jun 19, 2023

hswong3i commented Jun 20, 2023

alessfg commented Jun 21, 2023